🎨 Palette: [UX improvement] Semantic Modal Triggers#111
Conversation
💡 What: Changed the OSINT modal trigger from a standard link into a semantic button by adding `role="button"` and `aria-haspopup="dialog"`, and implemented `Spacebar` keyboard support. 🎯 Why: Using anchor tags (`<a href="#">`) to trigger modals is an accessibility anti-pattern. Screen readers won't announce them as buttons, and they do not inherently support the `Spacebar` to trigger actions, alienating keyboard-only users. ♿ Accessibility: Ensures assistive technologies correctly announce the trigger's behavior and allows keyboard navigation to match native `<button>` expectations.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Changed the OSINT modal trigger from a standard link into a semantic button by adding
role="button"andaria-haspopup="dialog", and implementedSpacebarkeyboard support.🎯 Why: Using anchor tags (
<a href="#">) to trigger modals is an accessibility anti-pattern. Screen readers won't announce them as buttons, and they do not inherently support theSpacebarto trigger actions, alienating keyboard-only users.📸 Before/After: Visual presentation is identical, but the internal semantics and keyboard behavior are greatly improved. (See UI screenshot of successful spacebar trigger execution)
♿ Accessibility: Ensures assistive technologies correctly announce the trigger's behavior and allows keyboard navigation to match native
<button>expectations.PR created automatically by Jules for task 9880498192207736696 started by @0m364