🎨 Palette: Semantic modal trigger accessibility#92
Open
0m364 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 What: Added
role="button"andaria-haspopup="dialog"to the#sitrep-btnlinks and bound akeydownevent listener for theSpacekey to open the modal.🎯 Why: Native
<a>tags withhref="#"used as modal triggers only respond to theEnterkey. Screen readers and keyboard users expect elements functioning as buttons to also respond to theSpacekey. These semantic attributes and keyboard behaviors align the UI element with standard accessibility expectations.📸 Before/After: N/A (Non-visual behavioral change)
♿ Accessibility: Improves screen reader context and provides full keyboard interactability for the OSINT/Sitrep modal triggers.
PR created automatically by Jules for task 12263013311770545656 started by @0m364