🎨 Palette: Add button semantics and Spacebar interaction to OSINT modal triggers#94
Conversation
…al triggers - Added `role="button"` and `aria-haspopup="dialog"` to `#sitrep-btn` links. - Added `Spacebar` keydown event listener to emulate native `<button>` behavior. - Documented learning in `.Jules/palette.md`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Added
role="button"andaria-haspopup="dialog"attributes to the "OSINT" anchor links across all pages (concepts.html,contact.html,products.html). Additionally, implemented akeydownevent listener inmodal.jsthat intercepts theSpacebarkey to open the modal while preventing the default page scrolling behavior.🎯 Why: The "OSINT" buttons are implemented using anchor (
<a>) tags withhref="#". Native anchors only trigger on theEnterkey, whereas keyboard users expect buttons to respond to bothEnterandSpacebar. Without proper ARIA roles, screen readers also fail to announce these elements as interactive dialog triggers. This enhancement ensures the modal is fully keyboard-accessible and semantically correct.📸 Before/After: Not visually impactful; the change is purely behavioral and semantic.
♿ Accessibility:
Spacebaractivation, aligning with native<button>behavior.PR created automatically by Jules for task 18352977169477102019 started by @0m364