Skip to content

🎨 Palette: Make sitrep modal trigger fully accessible#99

Open
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-a11y-modal-triggers-2346592942167315568
Open

🎨 Palette: Make sitrep modal trigger fully accessible#99
0m364 wants to merge 1 commit into
add-0m364-website-1232764033486168073from
palette-a11y-modal-triggers-2346592942167315568

Conversation

@0m364

@0m364 0m364 commented May 30, 2026

Copy link
Copy Markdown
Owner

💡 What: Added role="button" and aria-haspopup="dialog" to all <a href="#" id="sitrep-btn"> modal triggers, and updated modal.js to respond to the Spacebar key by opening the modal and preventing default page scrolling.

🎯 Why: Using anchor tags (<a>) as modal triggers without proper attributes breaks accessibility. Screen readers announce them as links instead of buttons, and native anchors only trigger via the Enter key. Keyboard users and screen readers expect buttons (which these logically are) to respond to both Enter and Spacebar.

📸 Before/After: Visuals remain exactly the same (this is purely an accessibility/semantic change).

♿ Accessibility: Ensures that keyboard-only users can correctly trigger the OSINT modal using the spacebar, and screen reader users hear it announced properly as a button that opens a dialog.


PR created automatically by Jules for task 2346592942167315568 started by @0m364

Added role="button" and aria-haspopup="dialog" to all <a> tags that trigger the OSINT modal, and bound spacebar keydown events to ensure screen reader and keyboard accessibility.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant