(pausable option A) Add PayloadSwitchSapient#93
Closed
ScreamingHawk wants to merge 7 commits intomasterfrom
Closed
(pausable option A) Add PayloadSwitchSapient#93ScreamingHawk wants to merge 7 commits intomasterfrom
ScreamingHawk wants to merge 7 commits intomasterfrom
Conversation
ScreamingHawk
force-pushed
the
payload-switch
branch
from
9143b12 to
3e64990
Compare
Agusx1211
changed the title
ScreamingHawk
commented
Apr 16, 2026
Comment on lines
+137
to
+139
| interface IPauseSource { | ||
| function paused() external view returns (bool); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Move to it's own file and inherit in PayloadSwitchSapient.
| revert ZeroAddress(); | ||
| } | ||
|
|
||
| isOperator[operator] = true; |
Contributor
Author
There was a problem hiding this comment.
emit OperatorSet
|
|
||
| /// @notice Disables ownership renunciation so the pause switch cannot become permanently stuck. | ||
| function renounceOwnership() public view override onlyOwner { | ||
| revert OwnershipRenunciationDisabled(); |
Contributor
Author
There was a problem hiding this comment.
transferOwnership(address(1)) effectively does the same
Contributor
Author
There was a problem hiding this comment.
Cleaner to remove the OZ ownable inheritance instead?
| /// - {HydrateProxy} for hydrate + execute flows | ||
| /// - {RequireUtils} for precondition checks | ||
| contract TrailsUtils is MalleableSapient, HydrateProxy, RequireUtils {} | ||
| contract TrailsUtils is MalleableSapient, HydrateProxy, RequireUtils { |
Contributor
Author
There was a problem hiding this comment.
Have we looked at including PayloadSwitchSapient in the inheritance graph? Fewer addresses to warm at the expense of flag/logic to split between recoverSapientSignature implementations.
Comment on lines
+73
to
+81
| /// @notice Updates whether `operator` is allowed to pause. | ||
| function setOperator(address operator, bool allowed) external onlyOwner { | ||
| if (operator == address(0)) { | ||
| revert ZeroAddress(); | ||
| } | ||
|
|
||
| isOperator[operator] = allowed; | ||
| emit OperatorSet(operator, allowed); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Move operator logic to parent contract and expose a modifier?
Member
|
Closed in favor of C |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to lock "subdigest" authorisations behind an ownable kill switch.
This replaces the current "subdigest" leaf. The leaf should instead be a sapient call to this contract and expect the image hash to be the same leaf digest as the wallet any address subdigest would have been.
For Trails, this gives Polygon the ability to lock preapproved payload interactions on a given chain with a single flag. This does not impact recovery or prevent the owner from interacting with the intent directly.