(pausable option B) Add pause at the module level#95
Closed
(pausable option B) Add pause at the module level#95
Conversation
|
|
||
| import {Self} from "src/base/Self.sol"; | ||
|
|
||
| abstract contract IPause is Self { |
| event OperatorSet(address indexed operator, bool allowed); | ||
|
|
||
| mapping(address => bool) private _operators; | ||
| bool private _paused; |
Contributor
There was a problem hiding this comment.
What if this was a feature level mapping instead. Then we can do granular locking.
mapping(bytes32 => bool) private _paused;
modifier whenNotPaused(bytes32 featureId) {
if (paused(featureId)) {
revert EnforcedPause();
}
_;
}
HydrateProxy
bytes32 HYDRATE_FEATURE_ID = bytes32(0xabc123);
function hydrateExecute(/*...*/) external payable whenActive(HYDRATE_FEATURE_ID)
Comment on lines
+33
to
+38
| modifier onlyDirectCall() { | ||
| if (address(this) != SELF) { | ||
| revert OnlyDirectCallAllowed(); | ||
| } | ||
| _; | ||
| } |
Comment on lines
+55
to
+59
| if (address(this) == SELF) { | ||
| return super.owner(); | ||
| } | ||
|
|
||
| return Pausable(SELF).owner(); |
Contributor
There was a problem hiding this comment.
This could be a modifier in Self
modifier forwardToSelf() {
if (address(this) != SELF) {
(bool ok, bytes memory ret) = SELF.staticcall(msg.data);
assembly {
if iszero(ok) {
revert(add(ret, 0x20), mload(ret))
}
return(add(ret, 0x20), mload(ret))
}
}
_;
}
Member
Author
|
Closed in favor of C |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an option to pause the modules helpers themselves and the sapient signer, allows adding pausable without SDK changes.