Open
Conversation
Closed
|
|
||
| /// @inheritdoc ISapientCompact | ||
| function recoverSapientSignatureCompact(bytes32, bytes calldata) external view returns (bytes32 imageHash) { | ||
| return paused ? PAUSED_IMAGE_HASH : UNPAUSED_IMAGE_HASH; |
Contributor
There was a problem hiding this comment.
This allows an integrator to use UNPAUSED_IMAGE_HASH as a valid state. If that's true, then this Sapient is effectively dictating multiple states through fixed image hashes. This is functionally equiv to #94 , but limited to 2 states.
I propose either throwing when paused or allowing arbitrary image hashes.
| revert ZeroAddress(); | ||
| } | ||
|
|
||
| isOperator[initialOperators[i]] = true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pausable sapient signer that must be used alongside a
NESTED_TREEleaf to add "pausable" functionality into any section of a sequence configuration tree.