Repository navigation
fix(room-kit): keep links in message order when splitting chat text - #1712
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
splitLinksAndContentreplaces each link in a message with a<link>marker and then fills the markers from the list of matched links withlinks.pop().pop()takes links from the end of the list, so a message with two or more links renders them in reverse order: the first marker shows the last link, and pressing it opens the wrong URL. The function is used for chat messages, HLS messages, overlay messages and the HLS description.This change takes links from the front of the list with
shift(). It also configures the package's Jest transform to use@react-native/babel-preset, becausemetro-react-native-babel-presetfrombabel.config.jsis not installed in this package, soyarn testcannot run any test today.Test command:
cd packages/react-native-room-kit && npx jest src/utils/functions.links.test.tsxFixes #1710
Additional context
Without the source change, the new order test fails (1 failed, 1 passed). With the change, both tests pass.
Pre-launch Checklist
ExampleAppChangelog.txtfile with relevant changes.///).