fix(evaos): use gateway tools for OpenClaw Mac control#691
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 30 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (20)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
evaOS review status: completedPR: #691 - fix(evaos): use gateway tools for OpenClaw Mac control evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #691 Review URL: #691 (review) |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![evaos-code-review-bot[bot]](https://avatars.githubusercontent.com/in/4184532?s=60&v=4){kind=small}
There was a problem hiding this comment.
Walkthrough
PR: #691 - fix(evaos): use gateway tools for OpenClaw Mac control
Head: 9e4f7f7fd5177fd3fd141b0d0d478c9bf8f6da4a into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 3/5 (~38 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
tests/unit/agent/agentCatalogProjection.test.ts |
modified | +32/-1 | Test coverage | Low |
tests/unit/renderer/AcpSendBox.dom.test.tsx |
modified | +57/-11 | Test coverage | Low |
tests/unit/renderer/LocalAgents.dom.test.tsx |
modified | +54/-0 | Test coverage | Low |
tests/unit/renderer/useGuidSend.dom.test.ts |
modified | +106/-5 | Test coverage | Low |
Review Signal
No validated inline findings.
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
No finding categories.
Validation and Proof
1 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
Proof status: sufficient - PR metadata mentions acceptable proof for each required validation recommendation.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #499, #655, #688, #623, #663.
Suggested labels: tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
|
Maintainer reviewer-availability waiver for exact head 9e4f7f7:
This waiver terminates only the unavailable reviewer slots for this exact head. Any head change resets the reviewer set and this waiver. |
1 participant
Pull Request
Description
This Priority-1 transport-truth slice stops Workbench from attaching unsupported per-session MCP payloads to genuine OpenClaw ACP conversations. OpenClaw now keeps
selected_session_mcp_serversempty while explicitly selected non-built-in MCP IDs remain preserved. Non-OpenClaw ACP behavior remains unchanged.The agent catalog also states the actual boundary: OpenClaw tools are gateway-managed, Workbench session MCP is unsupported, and the Desktop Bridge gateway plugin is required. Generic ACP support remains connection-time truth because the management catalog does not expose authoritative handshake capabilities.
Related Issues
Type of Change
Atomic PR Checklist
Local Checks
git diff --checkpassed.Runtime Verification
Agent Handoff
100yenadmin/evaOS-GUIbeta lineage.9e4f7f7fd5177fd3fd141b0d0d478c9bf8f6da4a.Screenshots
Not attached. Exact renderer DOM coverage asserts the new catalog copy; source review remains the pre-merge proof surface.
Additional Context
This PR preserves the enforced
no-acppackaging invariant and does not add a second Mac-control backend. It does not prove the Desktop Bridge plugin is installed, current, selected-scope authorized, or visibly invoked. No signed/notarized/stapled artifact, installed app, live broker/Mac control, customer readiness, public distribution, or release claim is made.