fix(workbench): own Mac bridge source#697
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
![evaos-code-review-bot[bot]](https://avatars.githubusercontent.com/in/4184532?s=60&v=4){kind=small}
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: ae9f35062f8a4b212fab4576d44602b57dc0303a into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~66 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/pr-checks.yml |
modified | +0/-1 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +11/-0 | Documentation | Moderate: validated P2 finding |
scripts/afterPack.js |
modified | +21/-1 | Changed file | Low |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +119/-109 | Changed file | Moderate: validated P2 finding |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +46/-0 | Test coverage | Low |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +65/-10 | Test coverage | Elevated: validated P1 finding |
Review Signal
Validated inline findings: 3 (P0: 0, P1: 1, P2: 2, P3: 0).
Dropped findings before posting: 0. High-severity findings: 1.
Risk Taxonomy
- Flaky test risk: 1
- Release regression: 1
- Runtime correctness: 1
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: bug, docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
evaOS review status: stale headPR: #697 - fix(workbench): own Mac bridge source evaOS review stopped because this queued head is no longer the live PR head. Automation note: agents should wait for this comment to reach PR URL: #697 |
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: 4bc6809882deef34eea7d0901639926eaf111922 into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~70 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/evaos-beta-rc-canary.yml |
modified | +146/-0 | Changed file | Moderate: validated P3 finding |
.github/workflows/evaos-live-canary-proof.yml |
modified | +11/-1 | Changed file | Low |
.github/workflows/pr-checks.yml |
modified | +0/-1 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +14/-0 | Documentation | Low |
scripts/afterPack.js |
modified | +28/-1 | Changed file | Low |
scripts/evaosBetaReleaseGate.js |
modified | +432/-6 | Changed file | Moderate: validated P2 finding |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +188/-111 | Changed file | Moderate: validated P2 finding |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +76/-2 | Test coverage | Low |
tests/unit/common-adapter/evaosIpcBridge.dom.test.ts |
modified | +27/-0 | Test coverage | Low |
tests/unit/evaos/NativeCompanionPage.dom.test.tsx |
modified | +67/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerSession.test.ts |
modified | +34/-0 | Test coverage | Low |
tests/unit/evaos/evaosNativeCompanionStatus.test.ts |
modified | +149/-6 | Test coverage | Low |
tests/unit/evaos/evaosNativeCompanionStatusHook.dom.test.tsx |
modified | +25/-0 | Test coverage | Low |
tests/unit/process/evaosBetaReleaseGate.test.ts |
modified | +331/-36 | Test coverage | Elevated: large change |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +349/-14 | Test coverage | Elevated: large change |
Review Signal
Validated inline findings: 4 (P0: 0, P1: 0, P2: 2, P3: 2).
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
- Proof gap: 1
- Release regression: 1
- Runtime correctness: 1
- Security boundary: 1
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: 50ee1c69caed64f908da20bb8fa62b3421ebfba2 into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~70 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/evaos-beta-rc-canary.yml |
modified | +170/-0 | Changed file | Low |
.github/workflows/evaos-live-canary-proof.yml |
modified | +11/-1 | Changed file | Low |
.github/workflows/pr-checks.yml |
modified | +10/-11 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +14/-0 | Documentation | Low |
scripts/afterPack.js |
modified | +28/-1 | Changed file | Low |
scripts/create-mock-release-artifacts.sh |
modified | +66/-2 | Changed file | Low |
scripts/evaosBetaReleaseGate.js |
modified | +483/-8 | Changed file | Elevated: validated P1 finding |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +188/-111 | Changed file | Elevated: large change |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +76/-2 | Test coverage | Low |
tests/unit/common-adapter/evaosIpcBridge.dom.test.ts |
modified | +51/-0 | Test coverage | Low |
tests/unit/evaos/NativeCompanionPage.dom.test.tsx |
modified | +153/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerSession.test.ts |
modified | +34/-0 | Test coverage | Low |
tests/unit/evaos/evaosDesktopBridgeSafety.test.ts |
added | +283/-0 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatus.test.ts |
modified | +300/-32 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatusHook.dom.test.tsx |
modified | +25/-0 | Test coverage | Low |
tests/unit/process/evaosBetaReleaseGate.test.ts |
modified | +424/-38 | Test coverage | Elevated: large change |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +365/-14 | Test coverage | Elevated: large change |
Review Signal
Validated inline findings: 1 (P0: 0, P1: 1, P2: 0, P3: 0).
Dropped findings before posting: 0. High-severity findings: 1.
Risk Taxonomy
- Release regression: 1
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: bug, docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: aa36bde5c675f35a66d336ba87ac3b8001cfc2b5 into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~70 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/evaos-beta-rc-canary.yml |
modified | +186/-0 | Changed file | Low |
.github/workflows/evaos-live-canary-proof.yml |
modified | +11/-1 | Changed file | Low |
.github/workflows/pr-checks.yml |
modified | +10/-11 | Changed file | Low |
.github/workflows/release-distribute.yml |
modified | +1/-0 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +14/-0 | Documentation | Low |
scripts/afterPack.js |
modified | +28/-1 | Changed file | Low |
scripts/create-mock-release-artifacts.sh |
modified | +66/-2 | Changed file | Low |
scripts/evaosBetaReleaseGate.js |
modified | +510/-8 | Changed file | Moderate: validated P3 finding |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +200/-112 | Changed file | Elevated: large change |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +76/-2 | Test coverage | Low |
tests/unit/common-adapter/evaosIpcBridge.dom.test.ts |
modified | +51/-0 | Test coverage | Low |
tests/unit/evaos/NativeCompanionPage.dom.test.tsx |
modified | +153/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerSession.test.ts |
modified | +34/-0 | Test coverage | Low |
tests/unit/evaos/evaosDesktopBridgeSafety.test.ts |
added | +283/-0 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatus.test.ts |
modified | +300/-32 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatusHook.dom.test.tsx |
modified | +25/-0 | Test coverage | Low |
tests/unit/process/evaosBetaReleaseGate.test.ts |
modified | +508/-40 | Test coverage | Elevated: large change |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +371/-14 | Test coverage | Elevated: large change |
Review Signal
Validated inline findings: 1 (P0: 0, P1: 0, P2: 0, P3: 1).
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
- Release regression: 1
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: f197d2e51828f9f6a50e8448a09d5b064d14b498 into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~70 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/evaos-beta-rc-canary.yml |
modified | +186/-0 | Changed file | Moderate: validated P2 finding |
.github/workflows/pr-checks.yml |
modified | +10/-11 | Changed file | Low |
.github/workflows/release-distribute.yml |
modified | +1/-0 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +14/-0 | Documentation | Low |
scripts/afterPack.js |
modified | +28/-1 | Changed file | Low |
scripts/create-mock-release-artifacts.sh |
modified | +66/-2 | Changed file | Moderate: validated P3 finding |
scripts/evaosBetaReleaseGate.js |
modified | +464/-7 | Changed file | Moderate: validated P2 finding |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +200/-112 | Changed file | Elevated: large change |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +76/-2 | Test coverage | Low |
tests/unit/common-adapter/evaosIpcBridge.dom.test.ts |
modified | +51/-0 | Test coverage | Low |
tests/unit/evaos/NativeCompanionPage.dom.test.tsx |
modified | +153/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerLiveCanary.test.ts |
modified | +69/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerSession.test.ts |
modified | +34/-0 | Test coverage | Low |
tests/unit/evaos/evaosDesktopBridgeSafety.test.ts |
added | +283/-0 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatus.test.ts |
modified | +300/-32 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatusHook.dom.test.tsx |
modified | +25/-0 | Test coverage | Low |
tests/unit/process/evaosBetaReleaseGate.test.ts |
modified | +485/-39 | Test coverage | Elevated: large change |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +370/-14 | Test coverage | Elevated: large change |
Review Signal
Validated inline findings: 3 (P0: 0, P1: 0, P2: 2, P3: 1).
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
- Flaky test risk: 1
- Release regression: 2
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
evaOS review status: stale headPR: #697 - fix(workbench): own Mac bridge source evaOS review stopped because this queued head is no longer the live PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Details: Superseded by a newer PR head. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
evaOS review status: completedPR: #697 - fix(workbench): own Mac bridge source evaOS review completed for this PR head. Automation note: agents should wait for this comment to reach PR URL: #697 Review URL: #697 (review) |
There was a problem hiding this comment.
Walkthrough
PR: #697 - fix(workbench): own Mac bridge source
Head: fff813ef1da6b766ae09344b20021b4a4b0672c4 into evaos/beta-rc-20260612. Review event: COMMENT.
Provider: GLM/Z.ai through ZCode (zcode-glm, zcode, model GLM-5.2).
Estimated review effort: 5/5 (~70 min)
Changed Files
| File | Status | Churn | Purpose | Risk |
|---|---|---|---|---|
.github/workflows/_build-reusable.yml |
modified | +2/-2 | Changed file | Low |
.github/workflows/evaos-beta-rc-canary.yml |
modified | +187/-1 | Changed file | Moderate: validated P3 finding |
.github/workflows/pr-checks.yml |
modified | +10/-11 | Changed file | Low |
.github/workflows/release-distribute.yml |
modified | +12/-2 | Changed file | Low |
.github/workflows/workbench-functional-smoke.yml |
modified | +4/-10 | Changed file | Low |
CHANGELOG.md |
modified | +14/-0 | Documentation | Low |
scripts/afterPack.js |
modified | +28/-1 | Changed file | Low |
scripts/create-mock-release-artifacts.sh |
modified | +66/-2 | Changed file | Moderate: validated P3 finding |
scripts/evaosBetaReleaseGate.js |
modified | +565/-7 | Changed file | Elevated: large change |
scripts/prepareEvaosDesktopBridgeResource.js |
modified | +200/-112 | Changed file | Moderate: validated P3 finding |
tests/unit/bootstrap/afterPackBundledResources.test.ts |
modified | +76/-2 | Test coverage | Low |
tests/unit/common-adapter/evaosIpcBridge.dom.test.ts |
modified | +51/-0 | Test coverage | Low |
tests/unit/evaos/NativeCompanionPage.dom.test.tsx |
modified | +153/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerLiveCanary.test.ts |
modified | +69/-0 | Test coverage | Low |
tests/unit/evaos/evaosBrokerSession.test.ts |
modified | +34/-0 | Test coverage | Low |
tests/unit/evaos/evaosDesktopBridgeControlSafetyP0.test.ts |
added | +425/-0 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosDesktopBridgeSafety.test.ts |
added | +358/-0 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatus.test.ts |
modified | +300/-32 | Test coverage | Elevated: large change |
tests/unit/evaos/evaosNativeCompanionStatusHook.dom.test.tsx |
modified | +25/-0 | Test coverage | Low |
tests/unit/evaos/evaosQaCanaryLocalControl.test.ts |
added | +418/-0 | Test coverage | Elevated: large change |
tests/unit/process/evaosBetaReleaseGate.test.ts |
modified | +639/-40 | Test coverage | Elevated: large change |
tests/unit/process/prepareEvaosDesktopBridgeResource.test.ts |
modified | +370/-14 | Test coverage | Elevated: large change |
Review Signal
Validated inline findings: 4 (P0: 0, P1: 0, P2: 0, P3: 4).
Dropped findings before posting: 0. High-severity findings: 0.
Risk Taxonomy
- Flaky test risk: 1
- Release regression: 1
- Runtime correctness: 1
- Security boundary: 1
Validation and Proof
2 required validation/proof recommendation(s) selected from changed files.
- required: TypeScript/web build or CI proof - Runtime TypeScript/web files or package/config files changed. Proof: npm run build; typecheck; focused Vitest; green GitHub check.
- required: CI/release smoke proof - CI, release, launchd, or package metadata changed. Proof: green GitHub check; release-status; coverage-audit; rollback note.
Proof status: missing - 1 required validation/proof recommendation(s) missing from PR metadata.
Profile validation hints: Do not ask for broad local suites when remote CI or fast-smoke proof is the right gate.
Profile proof expectations: Look for focused app smoke, packaged resource checks, or CI artifact proof when relevant.
Related Context
Related issues/PRs: #696, #623, #480.
Suggested labels: docs, tests.
Suggested reviewers: none from current metadata.
Review Settings Preview
- Profile: assertive
- Enabled sections: Review summary (inline_review); Walkthrough (inline_review); Changed-files table (walkthrough); Effort estimate (walkthrough); Related issues/PRs (walkthrough); Suggested labels (suggestion_only); Review status comment (sticky_status)
- Path instructions:
apps/eva-desktop-mac/**- Check macOS identity, helper path, TCC identity, and packaged resource shape risk. - Path instructions:
scripts/**- Treat release, packaging, and artifact-shape changes as high risk. - Label suggestions: workbench, macos, regression-hardening
- Reviewer suggestions: none
- Suggestion behavior: suggestions only; labels and reviewers are not auto-applied.
- Roadmap-only settings: auto-apply labels; auto-request reviewers; required status checks
Pre-merge checklist
- Inline comments target current RIGHT-side diff lines.
- No secret-like content survived into posted inline comments.
- REQUEST_CHANGES is only used when eligible P0/P1 findings survive validation.
- Required behavior proof is present or not applicable.
- Labels and reviewers are suggestions only; the bot did not auto-apply them.
|
Exact-head landing proof for fff813e:
This proves the vendored Workbench bridge source is ready to land. It is not signed/notarized artifact proof, runtime canary proof, publication proof, or a customer-readiness claim. |
1 participant
Pull Request
Description
Moves the Workbench Mac-control bridge into
evaOS-GUIas a pinned, vendored runtime and removes the release pipeline's checkout/runtime dependency on the archivedelectricsheephq/evaos-desktop-bridgerepository.The packaged bridge now routes
EvaDesktop,evaOS,evaOS Workbench, andcom.evaos.workbenchcompatibility inputs to the canonical/Applications/evaOS Workbench.appprocess. Strict packaging binds provenance to the exactevaOS-GUIcommit and rejects external source overrides, stale ownership metadata, digest drift, and the legacy/Applications/evaOS.apptarget.Related Issues
Type of Change
fix- Bug fix (non-breaking change which fixes an issue)feat- New feature (non-breaking change which adds functionality)perf- Performance improvementrefactor- Code restructuring (no behavior change)docs- Documentation updateAtomic PR Checklist (Rule 1)
<type>(<scope>): <subject>in EnglishLocal Checks (Rule 2)
bun run formatorbunx oxfmt --check <changed files>- formatting passesbun run lintor targetedbunx oxlint <changed files>- 0 errors (791 existing warnings)bunx tsc --noEmit- no type errorsbunx vitest run- 2,749 passed, 3 skipped across 298 filesbun run i18n:types+node scripts/check-i18n.js)git diff --check- no whitespace errorsRuntime Verification
Agent Handoff
100yenadmin/evaOS-GUI; archived bridge used only as recorded import provenanceresources/evaos-beta/bridge, bridge preparation/afterPack scripts, release workflows, focused tests, changelog/Volumes/LEXAR/Codex/evidence/evaos-workbench-runtime-reliability-release-train/v2136-vendored-bridge-dev-proof.noindexScreenshots
Not applicable; this is packaged runtime and release-pipeline ownership work.
Additional Context
The existing private v2.1.36 draft/tag at the prior beta head is superseded and will remain unpublished. It will be replaced only after this PR merges and exact-head CI, signed/notarized artifact verification, installed-app proof, and Mac-control canaries pass.