Feature/cleanup

Dockerfile

@@ -1,6 +1,6 @@
 # base image should be a PHP Debian container, such as php:7.4-buster
 ARG PHP_IMG
 FROM $PHP_IMG
 
 RUN apt-get update && \
     apt-get install -y \
@@ -64,8 +64,6 @@
       python3 \
       python3-pip \
       rsync \
-      ruby \
-      ruby-dev \
       shellcheck \
       software-properties-common \
       sshpass \
@@ -89,7 +87,7 @@
     rm -rf /var/lib/apt/lists/* && \
     localedef -i en_US -c -f UTF-8 -A /usr/share/locale/locale.alias en_US.UTF-8
 
-ENV LANG en_US.utf8
+ENV LANG="en_US.utf8"
 
 RUN echo "memory_limit=-1" > "$PHP_INI_DIR/conf.d/memory-limit.ini" && \
     echo "date.timezone=${PHP_TIMEZONE:-UTC}" > "$PHP_INI_DIR/conf.d/date_timezone.ini"
@@ -102,25 +100,20 @@
 
 ## set up NVM and install node ##
 
-ENV NVM_DIR /tmp/.nvm
+ENV NVM_DIR="/tmp/.nvm"
 RUN mkdir ${NVM_DIR}
-RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.3/install.sh | bash
+RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.40.4/install.sh | bash
 
 # Workaround - Cypress installation
-ENV CYPRESS_CACHE_FOLDER /tmp/cypress/cache
+ENV CYPRESS_CACHE_FOLDER="/tmp/cypress/cache"
 RUN mkdir -p ${CYPRESS_CACHE_FOLDER} && chmod 777 ${CYPRESS_CACHE_FOLDER}
 
-ARG NODE_VERSION=16
+ARG NODE_VERSION=24
 COPY build/install-node.sh /tmp/install-node.sh
-RUN chmod +x /tmp/install-node.sh && /tmp/install-node.sh "${NODE_VERSION}"
-COPY .bowerrc /root/.bowerrc
+RUN chmod +x /tmp/install-node.sh && /tmp/install-node.sh "--lts"
 
-## Compass ##
-
-RUN gem install compass
 
 ## Ansible, awscli, other Python tools ##
-
 COPY requirements.txt /tmp/requirements.txt
 RUN PIP_BREAK_SYSTEM_PACKAGES=1 python3 -m pip -V && \
     PIP_BREAK_SYSTEM_PACKAGES=1 python3 -m pip install --upgrade pip && \
@@ -129,8 +122,8 @@
 ## Composer ##
 ARG COMPOSER_VERSION 1
 
-ENV COMPOSER_ALLOW_SUPERUSER 1
-ENV COMPOSER_HOME /tmp
+ENV COMPOSER_ALLOW_SUPERUSER=""1
+ENV COMPOSER_HOME="/tmp"
 
 COPY build/install-composer.sh /tmp/install-composer.sh
 RUN /tmp/install-composer.sh && \
@@ -201,7 +194,7 @@
     chmod 700 /root/.ssh
 
 # force CI jobs to source root's .bashrc, which will enable NVM
-ENV BASH_ENV "/root/.bashrc"
+ENV BASH_ENV="/root/.bashrc"
 
 COPY ./entrypoint.sh /entrypoint.sh
 RUN chmod +x /entrypoint.sh

README.md

@@ -25,17 +25,7 @@
 - terminus
 - yamllint
 
-**npm packages installed:**
-- grunt-cli
-- gulp-cli
-- bower
-- yarn
-- lighthouse
-- serverless
-- firebase-tools
-- cypress
-
-Node and npm are managed by the `build/install-node.sh` script.
+Node and npm are managed by the `build/install-node.sh` script. The following versions are supported by default: [16, 18, 20, 22]
 
 ## Customize Package and Tool Configurations
 

build/install-node.sh

@@ -21,26 +21,13 @@ echo "Building node environment for version ${NODE_VERSION}"
 
 nvm install "${NODE_VERSION}"
 
-# Cypress version added since latest supports v18.x and above. Setting Cypress version to 13.1.0 according to cypress changelog for supporting node v16.x releases.
-# Lighthouse breaking changes for [v11.x / latest](https://github.com/GoogleChrome/lighthouse/releases/tag/v11.0.0), release tag for Aug 4, 2023. Setting latest stable version for node 16 support. (~10.4)
-npm install -g \
-    grunt-cli \
-    gulp-cli \
-    bower \
-    yarn \
-    lighthouse@~10.4 \
-    firebase-tools \
-    cypress@~13.1
-
-# TEMP FIX for issues with installing node 16
-# will be addressed in an upcoming version update
-if [[ "${NODE_VERSION}" != "16" ]];
-then
-  npm install -g serverless
-fi
-
 npm cache clean --force
 
 echo "node ${NODE_VERSION} build completed..."
 
-nvm alias default ${NODE_VERSION}
+if [[ "${NODE_VERSION}" =~ "lts" ]];
+then
+  nvm alias default 'lts/*'
+else
+  nvm alias default "${NODE_VERSION}"
+fi