Skip to content

fix: Workflow tool - Modify parameter name to match existing parameter name successfully #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Mar 27, 2026
+8 −0
Merged

fix: Workflow tool - Modify parameter name to match existing parameter name successfully #4967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ui/src/workflow/nodes/tool-base-node/component/input/InputFieldTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,14 @@ function deleteField(index: any) {
const currentIndex = ref<number | null>(null)
function refreshFieldList(data: any) {
if (currentIndex.value !== null) {
if (
inputFieldList.value
.filter((item, index) => index != currentIndex.value)
.some((field) => field.field == data.field)
) {
MsgError(t('workflow.tip.paramErrorMessage') + data.field)
return
}
inputFieldList.value?.splice(currentIndex.value, 1, data)
} else {
if (inputFieldList.value.some((field) => field.field == data.field)) {
Copy link
Copy Markdown
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided JavaScript code snippet appears to be part of a React component that manages an array of inputFieldList items. It contains a function deleteField for removing an item by its index and another function refreshFieldList for updating the list when fields are changed. Here's some feedback with suggested improvements:

Suggestions

  1. Null Coalescing Operator:

    • Use null coalescing operator (??) instead of checking currentIndex.value !== null.
    if (!currentIndex?.value) {
    // Handle error: currentIndex is not defined or is null/undefined
}

  2. Type Checking:

    • Ensure that inputFieldList and data.field are objects with consistent types.
    if (!(Array.isArray(inputFieldList) && typeof data.field === 'string')) {
    throw new Error('Invalid types');
}

  3. Avoid Multiple Function Calls within Conditionals:

    • Minimize the number of times you call functions inside conditional statements.
    if (
    inputFieldList.filter((item, index) => index != (currentIndex ?? 0)).some(
        (field) => field.field === data.field
    )
) {
    MsgError(t('workflow.tip.paramErrorMessage') + data.field);
    return;
}

  4. Optimize DOM Updates:

    • If performance is a concern, consider using batch updates for modifying arrays.
    if (
    !inputFieldList.some(({ field }) => field === data.field)
) {
    const newIndex = inputFieldList.findIndex(item => item.field === data.field ?? '');
    if (newIndex > -1) {
        inputFieldList.splice(newIndex, 0, data); // Add at front/new location
    } else {
        inputFieldList.push(data); // Append at end
    }
    currentIndex.value = newIndex; // Update current index
} else {
    msg.error(t('workflow.tip.paramErrorMessage') + data.field);
    return;
}

  5. String Interpolation:

    • Use template literals consistently throughout the codebase.
    if (!inputFieldList.some(item => item.field === `${data.field}`)) {
    currentIndex.value = inputFieldList.find(item => item.field === data.field)?.index || -1;
    if (currentIndex >= 0) {
        inputFieldList splice(currentIndex, 1, data);
    } else {
        inputFieldList.push(data);
    }
      }
  }

6. **Ensure Input Validation**:
   - Validate input arguments to avoid unexpected behavior.

   ```javascript
   if (!inputFieldList?.length || typeof data.field !== 'string') {
       console.error('Invalid parameters');
       return;
   }

By applying these suggestions, the code becomes more robust and efficient while maintaining readability.

Expand Down
Loading