Skip to content

Implement shared custom data (re-worked) based on the previous work from kitgxrl #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thebashpotato wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Implement shared custom data (re-worked) based on the previous work from kitgxrl #435

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a2e42de
Add transmitter sender data layer for asynchronous client
thebashpotato May 13, 2024
f828ec3
Fixed all clippy warnings.
thebashpotato May 14, 2024
b386b0c
Add transmitter sender data layer for raw client
thebashpotato May 14, 2024
82d5703
Refactor example code and documentation.
thebashpotato May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
target
target_ra
Copy link
Copy Markdown
Owner

@1c3t3a 1c3t3a May 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain where is this coming from? :) I assume it's not a cargo/rust folder?

Copy link
Copy Markdown
Author

@thebashpotato thebashpotato May 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to remove that, my neovim rust-analyzer setup creates a different folder for the analyzation to speed up development and avoid locks on the target directory. It becomes useful in large Rust codebases.

.vscode
.idea
ci/node_modules
Expand Down
1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
[workspace]
members = ["engineio", "socketio"]
resolver = "2"
2 changes: 1 addition & 1 deletion engineio/src/asynchronous/client/async_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ impl Debug for Client {
}
}

#[cfg(all(test))]
#[cfg(test)]
mod test {

use super::*;
Expand Down
2 changes: 1 addition & 1 deletion engineio/src/asynchronous/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
pub mod async_transports;
pub mod transport;

pub(self) mod async_socket;
mod async_socket;
#[cfg(feature = "async-callbacks")]
mod callback;
#[cfg(feature = "async")]
Expand Down
Loading