Allow shell configuration#260
Closed
Odonno wants to merge 1 commit into
Closed
Conversation
quangdang46
added a commit
to quangdang46/jcode
that referenced
this pull request
May 24, 2026
…) (#303) Port of upstream PR 1jehuang#260 (open). Lets users on nu / zsh / fish / pwsh have agent-spawned bash tool calls run through their preferred shell instead of the platform default. Config: [terminal] shell = 'nu' # or 'zsh', 'fish', 'pwsh', '/bin/dash' Env override: JCODE_SHELL=zsh Behavior: - shell unset → platform default (bash on Unix, cmd.exe on Windows) preserves existing behavior - shell set → spawn the named binary with '-c <command>' - shell name resolved via PATH; absolute paths supported Caveats (intentionally same as upstream): - Most shells accept '-c'; nu, zsh, bash, sh, fish (in some modes), pwsh (with '-Command' which we approximate via -c) - PowerShell users wanting full pwsh syntax should still wrap commands in 'pwsh -Command "..."' inside the agent prompt. Refs upstream PR 1jehuang#260.
Owner
|
Thanks for the effort, but this is out of scope for jcode right now and the repo no longer accepts external PRs. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257