fix(tui): sync copy selection via OSC52#332
Open
capt-marbles wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes copy-selection auto-copy behavior in browser-backed terminals such as cmux by emitting OSC 52 clipboard escape sequences in addition to existing host clipboard integrations.
Why
The current
copy_to_clipboardpath can succeed viawl-copy/arboardwhile only updating the remote host clipboard. In cmux/web terminals, users expect drag auto-selection copy to update the browser/local clipboard. OSC 52 is the terminal-native clipboard synchronization mechanism supported by many terminal frontends.Changes
wl-copyandarboardbehavior.Validation
cargo fmtcargo test clipboard_tests::osc52_clipboard_sequence --libcargo test test_copy_selection_mouse_drag_auto_copies_and_exits_mode --lib