Replace playerdb.co with mowojang.seraph.si, lower extreme cache TTL#4
Open
aidendotgg wants to merge 3 commits into
Open
Replace playerdb.co with mowojang.seraph.si, lower extreme cache TTL#4aidendotgg wants to merge 3 commits into
aidendotgg wants to merge 3 commits into
Conversation
Author
|
also preferably clear cache after pushing these changes to prod |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playerdb.co takes a long time to update the usernames of players and is generally pretty slow. mowojang.seraph.si is simply just a proxy of the actual mojang API and a mirror of the well known mowojang.matdoes.dev but with better hardware.
Also the 30 day cache expiry is pretty overkill so I lowered it to 1 day as I don't see any reason for it to be that long. Its only causing issues when searching by username. I swapped a username between an account nearly a week ago and its still looking up the old account when putting the username in. Its not because the old account hasn't logged into hypixel since the name change because it has, it seems to be the extremely long cache's doing. According to the comment "If this changes, update the Tip.js file in 25Karma" you will have to update that file.