Skip to content

Pass the canary's paid secrets only on a weekly run; the daily run stays free #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jehrr merged 1 commit into from
Oct 16, 2026
Merged

Pass the canary's paid secrets only on a weekly run; the daily run stays free #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ on:
# Once a day, off the hour, so it is not competing with everyone else's
# on-the-hour cron jobs for runner availability.
- cron: "23 6 * * *"
# Mondays: the same jobs, WITH the paid secrets (proxy, Scraping Browser,
# captcha key). On the daily run above those secrets read as empty, so
# it takes the free no-secret route and bills nothing.
- cron: "23 6 * * 1"

@claude claude Bot Oct 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two problems here:

  1. The comment names three paid secrets (proxy, Scraping Browser, captcha key). The workflow only references secrets.AMAZON_PROXY, and only that one is gated. Either the comment is wrong or the other secrets aren't gated.
  2. * * * already fires on Mondays. Both crons then trigger at 06:23, so Monday gets two runs: one with the proxy and one without. Make the daily cron 23 6 * * 2-6,0 if you don't want the duplicate.

The 0 1 schedule string also has to match github.event.schedule exactly. If the two ever drift apart, the paid run silently never gets the secret.

workflow_dispatch:

jobs:
Expand Down Expand Up @@ -84,7 +88,7 @@ jobs:
# Empty when the secret is not set, which env_config.py treats as
# unset — so this line is correct in both cases and needs no edit
# when the secret arrives. See the header.
AMAZON_PROXY: ${{ secrets.AMAZON_PROXY }}
AMAZON_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '23 6 * * 1') && secrets.AMAZON_PROXY || '' }}
run: |
set +e
python3 playwright_scraper.py \
Expand Down Expand Up @@ -267,7 +271,7 @@ jobs:
# interpretation step.
continue-on-error: true
env:
AMAZON_PROXY: ${{ secrets.AMAZON_PROXY }}
AMAZON_PROXY: ${{ (github.event_name != 'schedule' || github.event.schedule == '23 6 * * 1') && secrets.AMAZON_PROXY || '' }}
run: |
set +e
python3 playwright_scraper.py --mode product \
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@ one, and when it does the release notes say so first.

## [Unreleased]

### Changed

- CI only: the canary's optional paid secret `AMAZON_PROXY` now reaches it only on a new weekly
run (Mondays 06:23 UTC) and on a manual dispatch. The daily run keeps its

@claude claude Bot Oct 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bills nothing" is stated as fact but not measured. The change only blanks AMAZON_PROXY. The free route's behaviour with no proxy hasn't been shown, and the Monday daily-cron overlap still runs a proxy-less job alongside the paid one.

schedule and takes the free route without them, so it bills nothing.

## [0.2.0] — 2026-10-15

> **Behaviour changes from the 2026-10-14 audit fixes:**
Expand Down
Loading