Feat/#437 알림 전체 조회 API 구현 #445
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| // | ||
| // NotificationType+Data.swift | ||
| // ByeBoo-iOS | ||
| // | ||
| // Created by 더스틴 on 6/7/26. | ||
| // | ||
|
|
||
| extension NotificationType { | ||
|
|
||
| var responseKey: String { | ||
| switch self { | ||
| case .questOpen: | ||
| "QUEST_OPEN" | ||
| case .comment: | ||
| "COMMENT" | ||
| case .like: | ||
| "LIKE" | ||
| } | ||
| } | ||
|
|
||
| static func keyToEnum(_ key: String) -> Self? { | ||
| allCases.first { $0.responseKey == key } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| // | ||
| // NotificationListResponseDTO.swift | ||
| // ByeBoo-iOS | ||
| // | ||
| // Created by 더스틴 on 6/5/26. | ||
| // | ||
|
|
||
| struct NotificationListResponseDTO: Decodable { | ||
| let notifications: [NotificationResponseDTO] | ||
| } | ||
|
|
||
| struct NotificationResponseDTO: Decodable { | ||
| let notificationID: Int | ||
| let notificationType: String | ||
| let title: String | ||
| let content: String | ||
| let isRead: Bool | ||
| let createdAt: String | ||
| let landingURL: String | ||
| } | ||
|
Comment on lines
+12
to
+20
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
# NetworkService의 JSONDecoder 설정 확인
rg -n "keyDecodingStrategy|convertFromSnakeCase" --type swiftRepository: 36-APPJAM-HEARTZ/BYEBOO-iOS Length of output: 53 🏁 Script executed: #!/bin/bash
set -euo pipefail
# 1) Inspect the targeted DTO file around the reported lines
FILE="ByeBoo-iOS/ByeBoo-iOS/Data/Model/NotificationListReponseDTO.swift"
echo "---- ${FILE} ----"
nl -ba "$FILE" | sed -n '1,200p'
# 2) Check whether CodingKeys exists for NotificationResponseDTO (and nearby)
echo "---- CodingKeys in file ----"
rg -n "CodingKeys|notificationID|landingURL|NotificationResponseDTO" "$FILE"
# 3) Find JSONDecoder usage/config anywhere else
echo "---- JSONDecoder initialization/usages ----"
rg -n "JSONDecoder\(" --type swift
# 4) Look for any decode patterns that set decoder.keyDecodingStrategy explicitly
echo "---- keyDecodingStrategy assignments ----"
rg -n "keyDecodingStrategy" --type swift
# 5) Also search for CodingKeys implementations anywhere (to gauge existing approach)
echo "---- Any CodingKeys usage ----"
rg -n "enum CodingKeys" --type swiftRepository: 36-APPJAM-HEARTZ/BYEBOO-iOS Length of output: 208 🏁 Script executed: #!/bin/bash
set -euo pipefail
FILE="ByeBoo-iOS/ByeBoo-iOS/Data/Model/NotificationListReponseDTO.swift"
echo "== File exists? =="
ls -la "$FILE" || true
echo "== First 200 lines with numbers (using cat -n) =="
cat -n "$FILE" | sed -n '1,200p'
echo "== CodingKeys / NotificationResponseDTO in this file =="
rg -n "CodingKeys|enum CodingKeys|NotificationResponseDTO|notificationID|landingURL" "$FILE" || true
echo "== JSONDecoder initialization/usages across repo =="
rg -n "JSONDecoder\(" --type swift . || true
echo "== keyDecodingStrategy usage across repo =="
rg -n "keyDecodingStrategy|convertFromSnakeCase" --type swift . || true
echo "== Any enum CodingKeys usage across repo (spot check) =="
rg -n "enum CodingKeys" --type swift . | head -n 50 || trueRepository: 36-APPJAM-HEARTZ/BYEBOO-iOS Length of output: 2643 JSON 키 매핑(CodingKeys / snake_case 변환) 설정이 없어 디코딩 실패 가능
[resolve_review_comment in comment context not applicable] 🤖 Prompt for AI Agents |
||
|
|
||
| extension NotificationListResponseDTO { | ||
| func toEntity() -> NotificationListEntity { | ||
| let notifications = notifications.map { $0.toEntity() } | ||
| return .init(notifications: notifications) | ||
| } | ||
| } | ||
|
|
||
| extension NotificationResponseDTO { | ||
| func toEntity() -> NotificationEntity { | ||
| .init( | ||
| notificationID: notificationID, | ||
| notificationType: NotificationType.keyToEnum(notificationType), | ||
| title: title, | ||
| content: content, | ||
| isRead: isRead, | ||
| createdAt: createdAt, | ||
| landingURL: landingURL | ||
| ) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| // | ||
| // NotificationTokenAPI.swift | ||
| // ByeBoo-iOS | ||
| // | ||
| // Created by APPLE on 11/22/25. | ||
| // | ||
|
dev-domo marked this conversation as resolved.
|
||
|
|
||
| import Foundation | ||
|
|
||
| import Alamofire | ||
|
|
||
| enum NotificationTokenAPI { | ||
| case saveToken(dto: FCMTokenDTO) | ||
| case updateToken(dto: FCMTokenDTO) | ||
| case deleteToken(dto: FCMTokenDTO) | ||
| } | ||
|
|
||
| extension NotificationTokenAPI: EndPoint { | ||
|
|
||
| var basePath: String { | ||
| return "/api/v1/notification-tokens" | ||
| } | ||
|
|
||
| var path: String { | ||
| switch self { | ||
| case .saveToken, .updateToken, .deleteToken: | ||
| return "" | ||
| } | ||
| } | ||
|
|
||
| var method: HTTPMethod { | ||
| switch self { | ||
| case .saveToken: | ||
| return .post | ||
| case .updateToken: | ||
| return .patch | ||
| case .deleteToken: | ||
| return .put | ||
| } | ||
| } | ||
|
|
||
| var headers: HeaderType { | ||
| switch self { | ||
| case .saveToken, .updateToken, .deleteToken: | ||
| return .withAuth | ||
| } | ||
| } | ||
|
|
||
| var parameterEncoding: ParameterEncoding { | ||
| switch self { | ||
| case .saveToken, .updateToken, .deleteToken: | ||
| return JSONEncoding.default | ||
| } | ||
| } | ||
|
|
||
| var queryParameters: [String : String]? { | ||
| switch self { | ||
| case .saveToken, .updateToken, .deleteToken: | ||
| return nil | ||
| } | ||
| } | ||
|
|
||
| var bodyParameters: Parameters? { | ||
| switch self { | ||
| case .saveToken(let dto), .updateToken(let dto), .deleteToken(let dto): | ||
| return try? dto.toDictionary() | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Release 서명이 Development 프로필로 설정되어 배포 아카이브가 실패할 수 있습니다.
Line 352와 Line 375이 Release(iPhoneOS)에서
iPhone Developer+match Development ...를 사용하고 있어, Line 350의 Prod entitlements와 함께 배포용 서명 체인이 깨질 가능성이 큽니다. Release는 배포용 인증서/프로필로 분리해 주세요.수정 예시
Also applies to: 375-375
🤖 Prompt for AI Agents