Fix release manifest asset version rewrites for Homebrew and Scoop#1
Merged
Conversation
Agent-Logs-Url: https://github.com/4fuu/code-search-cli/sessions/ecb0743c-b3a3-4e80-87ba-f608d01a5115 Co-authored-by: 4fuu <96584640+4fuu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow updated manifest tag paths to the new version but left the embedded asset filename suffix at
v0.0.0. As a result, Scoop and Homebrew manifests could point at non-existent release assets even when the release itself was published correctly.Workflow generation
/home/runner/work/code-search-cli/code-search-cli/.github/workflows/release.yamlso manifest rendering rewrites both:/download/vX.Y.Z/)codes-vX.Y.Z-<target>)Checked-in package manifests
/home/runner/work/code-search-cli/code-search-cli/Formula/codes.rbto reference the actualv0.1.3archive names/home/runner/work/code-search-cli/code-search-cli/bucket/codes.jsonto reference the actualv0.1.3Windows zipImpact
v0.1.3assetscodes-v0.0.0-*URLssed -i -E "s|codes-v[0-9]+\.[0-9]+\.[0-9]+-x86_64-pc-windows-msvc\.zip|codes-$TAG-x86_64-pc-windows-msvc.zip|" ../bucket/codes.json