Skip to content
This repository was archived by the owner on Apr 25, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extension/src/background/service-worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ async function handleRequest(req: Request): Promise<Response> {
case 'get_page':
return await handleSnapshotRequest(req);
case 'click':
case 'scroll':
case 'type':
case 'wait':
return await forwardToContent(req);
Expand Down
31 changes: 31 additions & 0 deletions extension/src/content/content-script.ts
Original file line number Diff line number Diff line change
Expand Up @@ -448,6 +448,8 @@ async function handleMessage(req: ContentRequest): Promise<ContentResponse> {
return await handleSnapshot(req);
case 'click':
return await handleClick(req);
case 'scroll':
return await handleScroll(req);
case 'type':
return await handleType(req);
case 'wait':
Expand Down Expand Up @@ -646,6 +648,35 @@ async function handleType(req: ContentRequest): Promise<ContentResponse> {
}
}

async function handleScroll(req: ContentRequest): Promise<ContentResponse> {
const top = optionalNumber(req.params.top);
if (top === undefined) {
return { ok: false, error: 'top is required' };
}

cursorAgent.beginTask();
try {
window.scrollTo({
top: Math.max(0, top),
left: window.scrollX,
behavior: 'auto',
});
await nextFrame();

return {
ok: true,
data: {
action: 'scroll',
changed: true,
navigated: false,
scroll_top: window.scrollY,
},
};
} finally {
cursorAgent.endTask();
}
}

async function handleWait(req: ContentRequest): Promise<ContentResponse> {
const selector = optionalString(req.params.selector);
const timeout = optionalNumber(req.params.timeout) ?? DEFAULT_WAIT_TIMEOUT_MS;
Expand Down
10 changes: 9 additions & 1 deletion extension/src/shared/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,15 @@ export interface PageChunk {
}

export interface ContentRequest {
type: 'snapshot' | 'click' | 'type' | 'wait' | 'presence_start' | 'presence_stop' | 'resolve_url';
type:
| 'snapshot'
| 'click'
| 'scroll'
| 'type'
| 'wait'
| 'presence_start'
| 'presence_stop'
| 'resolve_url';
params: Record<string, unknown>;
}

Expand Down
102 changes: 88 additions & 14 deletions src/cli/commands.rs
Original file line number Diff line number Diff line change
Expand Up @@ -221,20 +221,19 @@ pub async fn page(
actions::GET_PAGE
};
let snapshot = fetch_snapshot(session_id, action).await?;
let resolved_page = if next || prev {
let viewport_height = snapshot.viewport.height.max(1.0);
let scroll_height = snapshot.scroll.height.max(viewport_height);
let total_pages = (scroll_height / viewport_height).ceil().max(1.0) as u32;
let current_page =
((snapshot.scroll.top / viewport_height).floor() as u32 + 1).clamp(1, total_pages);
let target = if next {
(current_page + 1).min(total_pages)
} else {
current_page.saturating_sub(1).max(1)
};
Some(target)
let resolved_page = resolve_requested_page(&snapshot, page_num, next, prev);
let snapshot = if let Some(target_page) = resolved_page {
send_ok(Request::new(
actions::SCROLL,
json!({
"session_id": session_id,
"top": scroll_top_for_page(&snapshot, target_page),
}),
))
.await?;
fetch_snapshot(session_id, actions::GET_PAGE_FRESH).await?
} else {
page_num
snapshot
};
let page_data = parse_page_from_snapshot(&snapshot, resolved_page)?;
println!("{}", crate::cli::output::format_page(&page_data, json_mode, verbose));
Expand Down Expand Up @@ -1200,6 +1199,44 @@ fn is_wait_timeout_error(response: &Response) -> bool {
.unwrap_or(false)
}

fn total_pages_for_snapshot(snapshot: &crate::protocol::messages::RawSnapshot) -> u32 {
let viewport_height = snapshot.viewport.height.max(1.0);
let scroll_height = snapshot.scroll.height.max(viewport_height);
(scroll_height / viewport_height).ceil().max(1.0) as u32
}

fn current_page_for_snapshot(snapshot: &crate::protocol::messages::RawSnapshot) -> u32 {
let viewport_height = snapshot.viewport.height.max(1.0);
let total_pages = total_pages_for_snapshot(snapshot);
((snapshot.scroll.top / viewport_height).floor() as u32 + 1).clamp(1, total_pages)
}

fn resolve_requested_page(
snapshot: &crate::protocol::messages::RawSnapshot,
page_num: Option<u32>,
next: bool,
prev: bool,
) -> Option<u32> {
let total_pages = total_pages_for_snapshot(snapshot);
if next || prev {
let current_page = current_page_for_snapshot(snapshot);
Some(if next {
(current_page + 1).min(total_pages)
} else {
current_page.saturating_sub(1).max(1)
})
} else {
page_num.map(|page| page.clamp(1, total_pages))
}
}

fn scroll_top_for_page(snapshot: &crate::protocol::messages::RawSnapshot, page_num: u32) -> f64 {
let viewport_height = snapshot.viewport.height.max(1.0);
let scroll_height = snapshot.scroll.height.max(viewport_height);
let max_scroll_top = (scroll_height - viewport_height).max(0.0);
((page_num.saturating_sub(1) as f64) * viewport_height).min(max_scroll_top)
}

fn print_json<T: Serialize>(value: &T) -> Result<()> {
println!("{}", serde_json::to_string_pretty(value)?);
Ok(())
Expand Down Expand Up @@ -1339,7 +1376,23 @@ fn validate_setup_args(browser: &str, extension_id: Option<&str>) -> Result<()>
mod tests {
use super::*;
use crate::page::structure::{Node, StoredBlock};
use crate::protocol::messages::Response;
use crate::protocol::messages::{RawSnapshot, Response, ScrollState, Viewport};

fn snapshot(scroll_top: f64, scroll_height: f64, viewport_height: f64) -> RawSnapshot {
RawSnapshot {
url: "https://example.com".into(),
title: "Example".into(),
viewport: Viewport {
width: 1280.0,
height: viewport_height,
},
scroll: ScrollState {
top: scroll_top,
height: scroll_height,
},
nodes: Vec::new(),
}
}

#[test]
fn native_host_manifest_supports_chrome() {
Expand Down Expand Up @@ -1515,6 +1568,27 @@ mod tests {
assert!(text.contains("--fresh"));
}

#[test]
fn resolve_requested_page_advances_to_adjacent_page() {
let snapshot = snapshot(850.0, 2400.0, 800.0);
assert_eq!(resolve_requested_page(&snapshot, None, true, false), Some(3));
assert_eq!(resolve_requested_page(&snapshot, None, false, true), Some(1));
}

#[test]
fn resolve_requested_page_clamps_explicit_page_to_bounds() {
let snapshot = snapshot(0.0, 1500.0, 800.0);
assert_eq!(resolve_requested_page(&snapshot, Some(0), false, false), Some(1));
assert_eq!(resolve_requested_page(&snapshot, Some(9), false, false), Some(2));
}

#[test]
fn scroll_top_for_page_caps_to_maximum_scroll_offset() {
let snapshot = snapshot(0.0, 1500.0, 800.0);
assert_eq!(scroll_top_for_page(&snapshot, 2), 700.0);
assert_eq!(scroll_top_for_page(&snapshot, 9), 700.0);
}

#[test]
fn resolve_element_target_accepts_prefixed_id() {
let page = PageData {
Expand Down
1 change: 1 addition & 0 deletions src/protocol/messages.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ pub mod actions {
pub const GET_PAGE_FRESH: &str = "get_page_fresh";
pub const SEARCH: &str = "search";
pub const CLICK: &str = "click";
pub const SCROLL: &str = "scroll";
pub const TYPE: &str = "type";
pub const WAIT: &str = "wait";
pub const GET_TEXT: &str = "get_text";
Expand Down