fix(tests): resolve uncollected weather tests and correct assertions (#161) - #201
Open
vaaiiibbhav wants to merge 1 commit into
Open
fix(tests): resolve uncollected weather tests and correct assertions (#161)#201vaaiiibbhav wants to merge 1 commit into
vaaiiibbhav wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
Fixes Issue #161
Changes:
Please list the central functionalities that have been changed:
tests/test_weather.pyFurther Details:
Summary:
WeatherCondclass (get_u()andget_v()methods) was completely broken and omitted during test collection.test_prefix, preventingpytestfrom discovering them.@pytest.mark.parametrizedid not match the function signatures.test_theta_from_uv.test_prefixes.u_res/v_res).pytest.approx()and updated the test data (windspeed = np.sqrt(2)) to ensure mathematical accuracy. Total active passing tests in this file increased from 4 to 12.Dependencies:
No new dependencies are required for this modification.
PR Checklist:
In the context of this PR, I: