Generate source verification inputs#108
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@coderabbitai review Please review the source-verification input generator, deterministic artifact output, local/CI gate wiring, release-manifest/checksum integration, and release docs updates. Claude is intentionally not requested for this PR. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughAdds a deterministic generator and tests for release-artifacts/latest/source-verification-inputs.json, integrates the artifact into release manifest/checksums, wires generation/check into Makefile and CI (with logs and syntax checks), updates shell/PowerShell check scripts, and updates documentation and operational state. ChangesSource Verification Inputs Generation and Release Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/generate_source_verification_inputs.py`:
- Around line 367-374: The deduplication currently uses JSON-stringified full
reference objects (all_links -> verification_links) which preserves different
position arrays and causes duplicate library entries; change the dedupe to key
by the (source, library) pair instead: after obtaining creation_links and
runtime_links from normalize_link_references, combine them and build a dict or
set keyed by (reference["source"], reference["library"]) keeping a single
representative reference for each key, then produce verification_links from
those unique entries so library_template (which consumes verification_links)
will no longer emit duplicate --libraries placeholders.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 57e235ae-0984-4de6-9fb6-6f778c7b3275
📒 Files selected for processing (23)
.github/workflows/ci.ymlCHANGELOG.mdMakefileREADME.mddocs/deployment.mddocs/release-policy.mddocs/status.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonrelease-artifacts/latest/source-verification-inputs.jsonscripts/check.ps1scripts/check.shscripts/generate_release_artifacts.pyscripts/generate_release_manifest.pyscripts/generate_source_verification_inputs.pyscripts/test_release_artifacts.pyscripts/test_release_manifest.pyscripts/test_source_verification_inputs.py
|
@coderabbitai review Latest head |
|
✅ Action performedReview finished.
|
1 participant
Summary
Implements issue #107 / P1-RELEASE-007 by adding a deterministic source-verification input bundle for Gate G release readiness.
scripts/generate_source_verification_inputs.pyandscripts/test_source_verification_inputs.py.release-artifacts/latest/source-verification-inputs.jsonfrom production contract config, Foundry artifacts, Solidity source files, compiler settings, and ABI/bytecode checksum outputs.forge verify-contractcommand templates without claiming live explorer verification before broadcast artifacts exist.make check,scripts/check.sh,scripts/check.ps1, and CI before release manifest/checksum validation.release-artifacts/latest/release-manifest.jsonand the signable checksum bundle.Closes #107.
Local Validation
python scripts\test_source_verification_inputs.pypython scripts\generate_source_verification_inputs.py --checkpython scripts\test_release_artifacts.pypython scripts\generate_release_artifacts.py --checkpython scripts\test_release_manifest.pypython scripts\generate_release_manifest.py --checkpython scripts\test_release_checksums.pypython scripts\generate_release_checksums.py --checkpython scripts\test_changelog_check.pypython scripts\check_changelog.pypython -m py_compile scripts\generate_release_artifacts.py scripts\test_release_artifacts.py scripts\generate_source_verification_inputs.py scripts\test_source_verification_inputs.py scripts\generate_release_manifest.py scripts\test_release_manifest.py scripts\generate_release_checksums.py scripts\test_release_checksums.py scripts\check_changelog.py scripts\test_changelog_check.pybash -n scripts/check.shscripts/check.ps1andscripts/bootstrap-windows.ps1git diff --checkmake checkpowershell -ExecutionPolicy Bypass -File scripts\check.ps1Summary by CodeRabbit
New Features
Documentation
Tests
Release Artifacts