Enforce production raw attribute schema#123
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (8)
🚧 Files skipped from review as they are similar to previous changes (4)
📝 WalkthroughWalkthroughThis PR enforces production raw-attribute schema: nonempty fragments must be comma-separated JSON objects each with exactly "trait_type" and "value" JSON string fields; StreamMetadataRenderer.isSafeRawAttributes was rewritten, tests added, docs/ops updated, and release/deployment checksums regenerated to reflect the bytecode change. ChangesProduction raw attribute schema enforcement
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@smart-contracts/StreamMetadataRenderer.sol`:
- Around line 306-309: The code currently treats whitespace-only fragments as
valid by skipping leading spaces then returning true when index == input.length;
change this so that in production schema mode a fragment that is only spaces is
rejected: after calling _skipRawAttributeSpaces(input, 0) and computing index,
if index == input.length then, when in production schema mode, return false
(reject) instead of true; keep the existing behavior outside production mode.
Update the branch that returns true to consult the production/schema-mode flag
and flip the result when appropriate so the "nonempty must be object sequence"
rule cannot be bypassed by whitespace-only input.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1c77452d-1b9d-44af-b02a-b693573b2020
📒 Files selected for processing (20)
CHANGELOG.mddeployments/address-books/anvil-6529stream-v0.1.0-001-broadcast.jsondeployments/address-books/anvil-6529stream-v0.1.0-001.jsondeployments/examples/anvil-6529stream-v0.1.0-001-broadcast.jsondeployments/examples/anvil-6529stream-v0.1.0-001.jsondocs/adr/0006-metadata-freeze.mddocs/known-blockers.mddocs/metadata.mddocs/status.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/abi-checksums.jsonrelease-artifacts/latest/release-artifact-manifest.jsonrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonrelease-artifacts/latest/source-verification-inputs.jsonsmart-contracts/StreamMetadataRenderer.soltest/README.mdtest/StreamMetadataEscaping.t.sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #122.
Refs #51.
Summary
StreamMetadataRenderer.isSafeRawAttributesso production token attributes are either empty or comma-separated objects with exactlytrait_typeandvalueJSON string fields.Notes
StreamCoreremains 24,135 runtime bytes with 441 bytes of EIP-170 headroom; linkedStreamMetadataRendereris 8,591 runtime bytes.Validation
powershell -NoProfile -ExecutionPolicy Bypass -File scripts\bootstrap-windows.ps1forge fmt smart-contracts\StreamMetadataRenderer.sol test\StreamMetadataEscaping.t.solforge fmt --check smart-contracts\StreamMetadataRenderer.sol test\StreamMetadataEscaping.t.solforge test --match-path test\StreamMetadataEscaping.t.sol -vvvmake release-checksumsmake checkpowershell -NoProfile -ExecutionPolicy Bypass -File scripts\check.ps1bash -n scripts/check.shgit diff --checkmake release-manifest-checkmake release-checksums-checkSummary by CodeRabbit
New Features
trait_typeandvaluestring fields; on-chain guard added.Documentation
Tests
Chores