Add drop authorization payload generator#181
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a deterministic, no-secret Python CLI to generate canonical unsigned EIP-712 drop authorization payloads for fixed-price and auction templates, with unit tests, committed fixtures, CI/local check integration, documentation updates, and updated release metadata/checksums. ChangesDrop Authorization Payload Generator
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
scripts/generate_drop_authorization_payload.py (1)
309-315: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winPreserve exception chain with
raise ... from exc.When re-raising in an exception handler, use
raise SystemExit(1) from excto preserve the chain orraise SystemExit(1) from Noneto suppress it explicitly.🔗 Recommended fix
except DropAuthorizationPayloadError as exc: print(f"drop authorization payload generation failed: {exc}", file=sys.stderr) - raise SystemExit(1) + raise SystemExit(1) from exc🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/generate_drop_authorization_payload.py` around lines 309 - 315, The exception handler for DropAuthorizationPayloadError should preserve or explicitly suppress the exception chain when re-raising SystemExit; update the except block that catches DropAuthorizationPayloadError (referencing main() and DropAuthorizationPayloadError) to use "raise SystemExit(1) from exc" to preserve chaining (or "from None" if you intend to suppress it) instead of the current plain "raise SystemExit(1)".
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/audit-package.md`:
- Around line 209-211: The maintenance checklist labeled "After editing this
file, run:" is missing the new payload-generator verification commands that were
added to the local verification block; update that checklist to include the
three commands — python scripts/test_drop_authorization_payload_generator.py,
python scripts/generate_drop_authorization_payload.py --input
test/fixtures/drop-authorization/payload-generator/fixed-price-input.json
--output
test/fixtures/drop-authorization/payload-generator/fixed-price-output.json
--check, and python scripts/generate_drop_authorization_payload.py --input
test/fixtures/drop-authorization/payload-generator/auction-input.json --output
test/fixtures/drop-authorization/payload-generator/auction-output.json --check —
so both sections list the same maintenance steps and keep the document
consistent.
In `@docs/incident-response.md`:
- Around line 282-286: Update the incident-response runbook wording so the
Recovery step instructs operators to hand the generated typed data (not just the
digest) to the approved signer; reference the no-secret unsigned payload
generator from docs/drop-authorization-signing.md and say to pass the generated
typed data to the signing system and optionally include the digest for
cross-checking/verification (e.g., for isValidSignature inputs), rather than
only “hand[ing] the generated digest to the approved signer.”
---
Outside diff comments:
In `@scripts/generate_drop_authorization_payload.py`:
- Around line 309-315: The exception handler for DropAuthorizationPayloadError
should preserve or explicitly suppress the exception chain when re-raising
SystemExit; update the except block that catches DropAuthorizationPayloadError
(referencing main() and DropAuthorizationPayloadError) to use "raise
SystemExit(1) from exc" to preserve chaining (or "from None" if you intend to
suppress it) instead of the current plain "raise SystemExit(1)".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5422001b-13fe-4428-8114-1edfc6a8845c
📒 Files selected for processing (27)
.github/workflows/ci.ymlCHANGELOG.mdMakefiledocs/audit-package.mddocs/drop-authorization-signing.mddocs/incident-response.mddocs/known-blockers.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check.ps1scripts/check.shscripts/check_audit_package.pyscripts/check_drop_authorization_fixtures.pyscripts/check_incident_response.pyscripts/check_release_readiness.pyscripts/generate_drop_authorization_payload.pyscripts/test_drop_authorization_payload_generator.pyscripts/test_release_readiness.pytest/fixtures/drop-authorization/payload-generator/auction-input.jsontest/fixtures/drop-authorization/payload-generator/auction-output.jsontest/fixtures/drop-authorization/payload-generator/fixed-price-input.jsontest/fixtures/drop-authorization/payload-generator/fixed-price-output.json
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #180.
Local validation
python -m py_compile scripts\generate_drop_authorization_payload.py scripts\test_drop_authorization_payload_generator.py scripts\check_drop_authorization_fixtures.py scripts\check_audit_package.py scripts\check_incident_response.py scripts\check_release_readiness.pypython scripts\test_drop_authorization_payload_generator.pypython scripts\generate_drop_authorization_payload.py --input test\fixtures\drop-authorization\payload-generator\fixed-price-input.json --output test\fixtures\drop-authorization\payload-generator\fixed-price-output.json --checkpython scripts\generate_drop_authorization_payload.py --input test\fixtures\drop-authorization\payload-generator\auction-input.json --output test\fixtures\drop-authorization\payload-generator\auction-output.json --checkpython scripts\test_drop_authorization_fixtures.pypython scripts\check_drop_authorization_fixtures.pypython scripts\test_audit_package.pypython scripts\check_audit_package.pypython scripts\test_incident_response.pypython scripts\check_incident_response.pypython scripts\test_release_readiness.pypython scripts\check_release_readiness.pypython scripts\generate_release_manifest.py --checkpython scripts\generate_release_checksums.py --checkpython scripts\check_changelog.pygit diff --checkpassed with only the existingscripts/check.ps1LF/CRLF warningmake checkSummary by CodeRabbit
New Features
Tests
Documentation
Chores