Add production release blocker report#205
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a deterministic production-focused blocker report: a new generator CLI with --check, comprehensive tests and fixtures, a committed Markdown artifact, CI/Makefile/WIndows wrapper wiring, release-manifest and checksum entries, and documentation updates that reference generation/check commands and artifact locations. ChangesProduction Release Blocker Report
Sequence DiagramsequenceDiagram
participant CI as CI pipeline (.github/workflows/ci.yml)
participant Make as Makefile / make check
participant CLI as generate_production_release_blocker_report.py
participant Evidence as release-artifacts/latest/public-beta-evidence.json
participant Templates as release-artifacts/evidence/production-release-templates
participant Manifest as scripts/generate_release_manifest.py
CI->>Make: run check targets
Make->>CLI: invoke generator (--check)
CLI->>Evidence: load & canonicalize evidence
CLI->>Templates: resolve/validate production templates
CLI->>Manifest: emit file_record entry (consumed later)
CLI->>CI: write or compare committed release-artifacts/latest/production-release-blockers.md
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/generate_production_release_blocker_report.py`:
- Around line 148-164: The loop that builds rows for PRODUCTION_REQUIREMENTS
must emit rows grouped by status; after filtering by statuses (inside the for
over PRODUCTION_REQUIREMENTS) collect matching requirement entries into a temp
list of tuples (status, requirement_id, row data) then sort that list using
STATUS_ORDER for the status key (and requirement_id as secondary tie-breaker)
before appending to rows — update the code around the for loop that reads
PRODUCTION_REQUIREMENTS/PRODUCTION_PHASE to perform this two-step
filter-then-sort-then-extend behavior (use template_paths and normalize_path as
before when creating row data); also add a unit test in
scripts/test_production_release_blocker_report.py that constructs a mixed-status
set of production requirements and asserts the produced rows are grouped by
STATUS_ORDER (and deterministic by requirement id) to lock the behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ff28e586-7da4-4c2f-8033-33e078088f24
📒 Files selected for processing (22)
.github/workflows/ci.ymlCHANGELOG.mdMakefileREADME.mddocs/public-beta-evidence.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/production-release-blockers.mdrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check.ps1scripts/check_release_readiness.pyscripts/generate_production_release_blocker_report.pyscripts/generate_release_artifacts.pyscripts/generate_release_manifest.pyscripts/test_production_release_blocker_report.pyscripts/test_release_artifacts.pyscripts/test_release_manifest.py
Summary
Closes #203.
This PR adds a production-focused release blocker report generated from the existing public beta evidence manifest and production release evidence templates.
It wires the new report into:
make checkandscripts/check.ps1gatesThe new report links each production requirement back to its checked template path and preserves the current readiness posture. This does not change Solidity, deployment behavior, or any release-readiness claim.
Validation
python -m py_compile scripts/generate_production_release_blocker_report.py scripts/test_production_release_blocker_report.py scripts/generate_release_manifest.py scripts/test_release_manifest.py scripts/check_release_readiness.pypython scripts/test_production_release_blocker_report.pypython scripts/generate_production_release_blocker_report.py --checkpython scripts/test_release_artifacts.pypython scripts/test_release_manifest.pypython scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/generate_public_beta_blocker_report.py --checkpython scripts/generate_release_manifest.pypython scripts/generate_release_checksums.pypython scripts/test_public_beta_blocker_report.pypython scripts/generate_public_beta_blocker_report.py --checkpython scripts/test_release_checksums.pypython scripts/generate_release_checksums.py --checkpython scripts/check_public_beta_evidence.pypython scripts/check_non_local_release_evidence.pypython scripts/test_changelog_check.pypython scripts/check_changelog.pypython scripts/test_audit_package.pypython scripts/check_audit_package.pypython scripts/test_architecture_threat_model.pypython scripts/check_architecture_threat_model.pymake checkpowershell -ExecutionPolicy Bypass -File scripts\check.ps1git diff --checkSummary by CodeRabbit
New Features
Documentation
Chores
Tests