Guard release evidence tracker closure state#248
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
✅ Files skipped from review due to trivial changes (7)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a deterministic closure/readiness checker and tests that load and cross-validate committed release-evidence artifacts, optionally audit a live GitHub issue snapshot, and wire the check into CI/Makefile/local scripts, release-readiness enforcement, and documentation. ChangesRelease Evidence Closure Readiness Validator
🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related issues
Possibly Related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
Contributor
Author
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/public-beta-evidence.md`:
- Around line 86-91: Update the closure-check documentation to mention the
backlog JSON input alongside the other inputs: in docs/public-beta-evidence.md
(lines 86-91) add "release-evidence-issue-backlog.json" to the list of things
the release evidence issue closure checker loads; in docs/release-readiness.md
(lines 41-44) add the backlog JSON to the dashboard note so the dashboard is
described as loading the tracker map, body-sync artifact, packet index, evidence
manifest, and release-evidence-issue-backlog.json; in docs/tooling.md (lines
280-293) add the backlog JSON to the live-audit instructions so the live-audit
step explicitly lists release-evidence-issue-backlog.json as an input; and in
release-artifacts/README.md (lines 185-190) add
release-evidence-issue-backlog.json to the closure-check overview list of
inputs.
- Around line 86-91: The doc text must explicitly list the backlog artifact that
the checker reads: update the sentence describing inputs to include "the
release-evidence-issue-backlog.json backlog artifact" in addition to the
committed tracker map, body-sync artifact, packet index, and public-beta
evidence manifest; reference the checker script name
check_release_evidence_issue_closure.py in the change so readers know this file
loads that backlog JSON before validating closure state.
In `@scripts/check_release_evidence_issue_closure.py`:
- Around line 181-182: The call to body_checker.expected_issue_rows in main()
can raise the body-checker's own exception type and bypass this script's error
normalization; wrap the call in a try/except that catches all exceptions raised
by body_checker.expected_issue_rows and re-raise them as the script's checker
error type (e.g., raise CheckerError(...) from e) so main() and the existing
error-handling path receive a normalized CheckerError; update the block around
body_checker.expected_issue_rows(...) in main() accordingly to perform this
catch-and-wrap.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 1cdc1c94-9d2d-4119-aaff-13ebc74349cd
📒 Files selected for processing (18)
.github/workflows/ci.ymlCHANGELOG.mdMakefiledocs/public-beta-evidence.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check.ps1scripts/check.shscripts/check_release_evidence_issue_closure.pyscripts/check_release_readiness.pyscripts/test_release_evidence_issue_closure.pyscripts/test_release_readiness.py
Contributor
Author
|
@coderabbitai review Follow-up commit
Local validation passed:
|
|
✅ Action performedReview finished.
|
This was referenced Jun 13, 2026
punk6529
added a commit
that referenced
this pull request
Jun 13, 2026
This was referenced Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/check_release_evidence_issue_closure.pyand focused tests for deterministic release evidence tracker closure/readiness validation.gh issue list --state all --json number,title,state, including premature-closure remediation and UTF-8 BOM snapshot support.Closes #246.
Validation
python scripts/test_release_evidence_issue_closure.pypython scripts/check_release_evidence_issue_closure.pypython -m py_compile scripts/check_release_evidence_issue_closure.py scripts/test_release_evidence_issue_closure.pypython scripts/test_release_evidence_issue_bodies.pypython scripts/check_release_evidence_issue_bodies.pypython scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/generate_release_manifest.py --checkpython scripts/generate_release_checksums.py --checkpython scripts/test_changelog_check.pypython scripts/check_changelog.pybash -n scripts/check.shscripts\check.ps1rg -n "^#|^##|^###" ops\ROADMAP.md ops\AUTONOMOUS_RUN.md docs\release-readiness.md docs\public-beta-evidence.md docs\tooling.md release-artifacts\README.mdgit diff --checkgh issue list --repo 6529-Collections/6529Stream --state all --limit 100 --json number,title,statetotmp\release-evidence-issue-closure.json, then ranpython scripts/check_release_evidence_issue_closure.py --live-json tmp\release-evidence-issue-closure.jsonSummary by CodeRabbit
New Features
Tests
Documentation
Chores