Add non-local evidence generator#252
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (5)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughAdds a CLI and tests to generate checker-compatible non-local release evidence JSON from committed templates and retained artifacts (automatic SHA-256 computation and --check drift detection), integrates tests into check scripts, updates runbook/tooling docs and changelog, and refreshes release-artifact manifest checksums and ops/run state. ChangesEvidence Generator Implementation, Testing, and CI Integration
Documentation and Intake Runbook Updates
Release Artifact Metadata Updates
Operational State and Roadmap Updates
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/non-local-release-evidence.md`:
- Around line 110-115: The text incorrectly implies the generator shells out to
the checker; update the sentence to clarify that
scripts/generate_non_local_release_evidence.py performs its own in-process
validation and does not call or run scripts/check_non_local_release_evidence.py
before writing, and state that running
scripts/check_non_local_release_evidence.py is a separate, optional post-write
verification step the operator can run manually; reference both script names in
the revised sentence so readers know which tool does in-process validation and
which is a separate checker.
In `@ops/AUTONOMOUS_RUN.md`:
- Line 39: The row text is imprecise: change the phrase "TBD after issue `#251`
merges" to a precise handoff trigger; update that cell to read either "TBD after
PR `#252` merges" or "TBD after issue `#251` closes" so the durable state is
accurate (edit the table row currently containing "Next issue | TBD after issue
`#251` merges" to use the chosen wording).
- Around line 217-234: The validation list is missing the generator's
drift-detection check; add the command "python
scripts/generate_non_local_release_evidence.py --check" into the Completed local
validation block so the audit trail records the generator's own --check run
(insert it alongside the other script checks in the same list).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: bc74d0be-79a9-4d81-a962-30d036fb89ab
📒 Files selected for processing (12)
CHANGELOG.mddocs/non-local-release-evidence.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/check.ps1scripts/check.shscripts/generate_non_local_release_evidence.pyscripts/test_non_local_release_evidence_generator.py
|
Pushed a CI repair in Local follow-up validation passed:
|
Summary
scripts/generate_non_local_release_evidence.py, a no-secret helper that builds checker-compatible evidence metadata from an existing requirement template plus a retained artifact and computes the retained artifact digest automatically.--checkdrift detection, missing retained artifacts, and reviewed-evidence reviewer enforcement.Closes #251.
Validation
python -m py_compile scripts/generate_non_local_release_evidence.py scripts/test_non_local_release_evidence_generator.pypython scripts/test_non_local_release_evidence_generator.pypython scripts/test_non_local_release_evidence.pypython scripts/check_non_local_release_evidence.pypython scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/test_release_manifest.pypython scripts/generate_release_manifest.py --checkpython scripts/test_release_checksums.pypython scripts/generate_release_checksums.py --checkpython scripts/test_changelog_check.pypython scripts/check_changelog.pybash -n scripts/check.shscripts/check.ps1rg -n "^#|^##|^###" ops\ROADMAP.md ops\AUTONOMOUS_RUN.md docs\non-local-release-evidence.md docs\tooling.mdgit diff --checkSummary by CodeRabbit
New Features
Documentation
Tests
Chores