Add release evidence live audit orchestrator#266
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
📝 WalkthroughWalkthroughAdds a Python orchestrator to export and validate live release-evidence issue snapshots (profiles: labels, bodies, closure), unit tests that mock subprocesses, CI/build wiring to run the new tests, operator documentation updates, and updated release-artifact checksums and operational run state. ChangesLive Audit Orchestrator Feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
punk6529
force-pushed
the
codex/release-evidence-live-audit-orchestrator
branch
from
fe618ac to
13a7b80
Compare
|
@coderabbitai review latest head |
|
✅ Action performedFull review finished. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scripts/audit_release_evidence_issue_snapshots.py (1)
37-45: ⚡ Quick winConsider extracting
positive_intto a shared utility module.This function is duplicated from
export_release_evidence_issue_snapshot.py(lines 140-150). Extracting it to a shared module would improve maintainability.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/audit_release_evidence_issue_snapshots.py` around lines 37 - 45, The positive_int function is duplicated; extract it into a shared utility module (e.g., create a new module like utils/argparse_helpers.py) containing the same positive_int(value: str) -> int implementation and docstring, preserve the exact argparse.ArgumentTypeError messages and behavior, then replace the local definitions in both scripts with a single import (from utils.argparse_helpers import positive_int) and remove the duplicate function bodies from each script; update any imports and run linters/tests to ensure no breakage.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@scripts/audit_release_evidence_issue_snapshots.py`:
- Around line 37-45: The positive_int function is duplicated; extract it into a
shared utility module (e.g., create a new module like utils/argparse_helpers.py)
containing the same positive_int(value: str) -> int implementation and
docstring, preserve the exact argparse.ArgumentTypeError messages and behavior,
then replace the local definitions in both scripts with a single import (from
utils.argparse_helpers import positive_int) and remove the duplicate function
bodies from each script; update any imports and run linters/tests to ensure no
breakage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: edfd66cd-f841-453d-a1af-d1250f88b51d
📒 Files selected for processing (17)
.github/workflows/ci.ymlCHANGELOG.mdMakefiledocs/public-beta-evidence.mddocs/release-readiness.mddocs/tooling.mdops/AUTONOMOUS_RUN.mdops/ROADMAP.mdrelease-artifacts/README.mdrelease-artifacts/latest/SHA256SUMSrelease-artifacts/latest/release-checksums.jsonrelease-artifacts/latest/release-manifest.jsonscripts/audit_release_evidence_issue_snapshots.pyscripts/check.ps1scripts/check.shscripts/check_release_readiness.pyscripts/test_release_evidence_issue_snapshot_audit.py
|
Addressed the CodeRabbit helper-deduplication nit in Validation after the follow-up:
|
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ops/AUTONOMOUS_RUN.md (1)
202-226: 💤 Low valueValidation list is comprehensive and well-documented.
The follow-up section properly documents the CodeRabbit review nit (helper deduplication), the local fix (extraction to
scripts/argparse_helpers.py), and an exhaustive validation run covering unit tests, Python compilation, tooling checks, shell/PowerShell syntax, heading validation, and git diff checks—all aligned with the PR objectives and the earlier validation promise.However, one minor clarity improvement: the document shows CI run
27477620425on head13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005, which differs from the opening PR headfe618aca88ba5af68196d61c6cb7af11a2ac0327. A brief note that the CI run was on the follow-up commit after addressing the CodeRabbit nit would clarify the intended timeline (i.e., "...after follow-up extraction work, GitHub Actions CI run27477620425passed on updated head13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005").🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ops/AUTONOMOUS_RUN.md` around lines 202 - 226, Add a brief clarifying note that the referenced GitHub Actions CI run 27477620425 ran on the follow-up commit (head 13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005) after addressing the CodeRabbit nit (extraction to argparse_helpers.py), e.g., append a short sentence to the follow-up/validation paragraph stating that CI run 27477620425 passed on updated head 13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005 to make the timeline explicit.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ops/AUTONOMOUS_RUN.md`:
- Around line 202-226: Add a brief clarifying note that the referenced GitHub
Actions CI run 27477620425 ran on the follow-up commit (head
13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005) after addressing the CodeRabbit nit
(extraction to argparse_helpers.py), e.g., append a short sentence to the
follow-up/validation paragraph stating that CI run 27477620425 passed on updated
head 13a7b80bd2dc3cbb695a1d1ef7d6e3e29f20c005 to make the timeline explicit.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 311c5ebd-60f0-4778-bc52-32222140a82c
📒 Files selected for processing (7)
.github/workflows/ci.ymlops/AUTONOMOUS_RUN.mdscripts/argparse_helpers.pyscripts/audit_release_evidence_issue_snapshots.pyscripts/export_release_evidence_issue_snapshot.pyscripts/test_release_evidence_issue_snapshot.pyscripts/test_release_evidence_issue_snapshot_audit.py
✅ Files skipped from review due to trivial changes (1)
- scripts/argparse_helpers.py
🚧 Files skipped from review as they are similar to previous changes (3)
- .github/workflows/ci.yml
- scripts/test_release_evidence_issue_snapshot_audit.py
- scripts/audit_release_evidence_issue_snapshots.py
1 participant
Summary
scripts/audit_release_evidence_issue_snapshots.py, an operator-only no-secret orchestrator that exports and checks live release evidence issue snapshots for labels, bodies, and closure state.Validation
python scripts/test_release_evidence_issue_snapshot_audit.pypython scripts/audit_release_evidence_issue_snapshots.py --helppython scripts/check_release_readiness.pypython scripts/test_release_readiness.pypython scripts/generate_release_manifest.py --checkpython scripts/test_release_manifest.pypython scripts/generate_release_checksums.py --checkpython scripts/test_release_checksums.pypython scripts/check_changelog.pypython -m py_compile scripts/audit_release_evidence_issue_snapshots.py scripts/test_release_evidence_issue_snapshot_audit.pybash -n scripts/check.sh[scriptblock]::Create((Get-Content scripts/check.ps1 -Raw)) | Out-Nullrg -n "^#|^##|^###" ops/ROADMAP.md ops/AUTONOMOUS_RUN.md docs/tooling.md docs/public-beta-evidence.md docs/release-readiness.md release-artifacts/README.md CHANGELOG.mdgit diff --checkpassed with only Git's existing Windows line-ending warning forscripts/check.ps1powershell -ExecutionPolicy Bypass -File scripts/bootstrap-windows.ps1powershell -ExecutionPolicy Bypass -File scripts/check.ps1Closes #265
Summary by CodeRabbit
New Features
Tests
Documentation
Chores