[codex] Add fixed-price drop flow spec#393
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (24)
📝 WalkthroughWalkthroughAdds ChangesINT-002 Fixed-Price Mint Flow Spec
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
6529bot follow-up commit review - 73b7da5Verdict: No new findings This follow-up commit ( Reviewing the full change set: the new doc, checker, tests, and gate wiring are internally consistent. The checker's required headings, phrases, commands, and link targets all match the committed One minor observation worth confirming (not blocking): the doc asserts payment splits as No accessibility/i18n/security concerns apply to this docs-and-tooling change. |
6529bot follow-up commit review - 70712edVerdict: No new findings This follow-up adds two small commits: the AUTONOMOUS_RUN.md PR-state update (PATCH 2/3 filling in the #393 URL, identical bookkeeping to the prior The bookkeeping edit is accurate: Resolved since last reviewThe prior open observation about the payment-split ratios ( No accessibility/i18n/security concerns apply to this docs-and-bookkeeping change. |
|
Follow-up clarification: the payment-split drift observation is addressed in latest head Specifically:
Focused validation after that change:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Merge decision for head
Proceeding with merge. |
Summary
Adds the INT-002 fixed-price mint and drop authorization integration flow spec for frontend, mobile, Electron, indexer, operator UI, and backend-signing consumers.
This PR adds
docs/integrations/contract-flows.mdcovering source-of-truth artifacts, preflight reads, EIP-712 and ERC-1271 signing paths,mintDropsubmission, events, payment credits, withdrawals, curator reserve accounting, failure states, frontend state transitions, and backend signing-service boundaries. It also adds a checker/test pair so required maturity language, flow-critical terms, source links, and validation commands cannot drift.The repo remains pre-audit and not production-ready; this is integration documentation and gate coverage only, not public-beta, marketplace, signing-service, or live deployment evidence.
Closes #392.
Validation
Focused checks run in
D:\repos\6529Stream-pr-ci-hardeningand repeated in the clean publishing clone where relevant:python scripts/test_contract_flows.pypython scripts/check_contract_flows.pypython scripts/test_integrations_readme.pypython scripts/check_integrations_readme.pypython scripts/test_release_readiness.pypython scripts/check_release_readiness.pypython scripts/test_release_manifest.pypython scripts/generate_release_manifest.py --checkpython scripts/test_bytecode_release_proof.pypython scripts/generate_bytecode_release_proof.py --checkpython scripts/test_release_checksums.pypython scripts/generate_release_checksums.py --checkpython scripts/test_risk_register.pypython scripts/check_risk_register.pypython scripts/generate_risk_register.py --checkpython scripts/check_changelog.pypython -m py_compile scripts/check_contract_flows.py scripts/test_contract_flows.pygit diff --checkpowershell -NoProfile -ExecutionPolicy Bypass -File scripts\check.ps1passed locally at 2026-06-15 09:22 UTC after running outside the workspace sandbox so the installed Foundry binary could execute.Notes
out/; the flow points integrators to tracked ABI surface/checksum artifacts and address books.Summary by CodeRabbit
New Features
Documentation