Skip to content

[WIP] Fix bug with ID 40cf72f23045#37

Closed
9thLevelSoftware with Copilot wants to merge 1 commit into
beta0.2.1from
copilot/fix-bug-40cf72f23045
Closed

[WIP] Fix bug with ID 40cf72f23045#37
9thLevelSoftware with Copilot wants to merge 1 commit into
beta0.2.1from
copilot/fix-bug-40cf72f23045

Conversation

Copilot AI commented Dec 31, 2025

Copy link
Copy Markdown
Contributor
  • Understand bugfix commit 40cf72f
  • Apply audio attributes updates in HapticFeedbackEffect.android.kt (changed USAGE_ASSISTANCE_SONIFICATION to USAGE_GAME)
  • Add test sounds button to Settings UI in HistoryAndSettingsTabs.kt
  • Wire up onTestSounds callback in NavGraph.kt
  • Apply refactoring changes to WorkoutTab.kt (formatReps usage and auto-continue timer)
  • Verify all changes match the bugfix intent

Summary of Changes

Audio Attributes Update (HapticFeedbackEffect.android.kt)

  • Changed AudioAttributes.USAGE_ASSISTANCE_SONIFICATION to AudioAttributes.USAGE_GAME
  • Benefits:
    1. Ties sounds to media volume instead of notification volume
    2. Allows sounds to play through Do Not Disturb mode
    3. Better mixing with music without interrupting playback
  • Applied to both SoundPool and MediaPlayer fallback

Test Sounds Button (HistoryAndSettingsTabs.kt + NavGraph.kt)

  • Added "Test Sounds" button in Developer Tools section of Settings
  • Wired up to viewModel.testSounds() which plays sample workout sounds
  • Helps users test audio configuration and volume levels

Minor Refactoring (WorkoutTab.kt)

  • Use formatReps() helper function for consistent rep display
  • Increased auto-continue countdown from 5 to 10 seconds for better UX

All changes are ready to be merged to main.

Original prompt

I need this bugfix merged to Main: 40cf72f


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants