Refresh Smart Insights timestamp at data fetch time

[9thLevelSoftware]

Motivation

• Ensure all SmartSuggestions and Readiness cutoffs use a timestamp that reflects the moment data is fetched so week/day windows stay aligned with the latest refresh cycle.
• Prevent stale nowMs values from causing inconsistent insight calculations after background refreshes or profile changes.

Description

• Replace the immutable remembered timestamp with mutable state via var nowMs by remember { mutableStateOf(currentTimeMillis()) } in SmartInsightsContent.
• Capture a fresh timestamp at fetch time by setting nowMs = currentTimeMillis() at the start of the LaunchedEffect(profileId) fetch flow.
• Use the refreshed nowMs when calling repository functions (fetch window) and include nowMs in memoization keys for remember on weeklyVolume, balanceAnalysis, neglectedExercises, and readiness so downstream SmartSuggestionsEngine and ReadinessEngine computations align with the latest refresh.

Testing

• Ran ./gradlew :shared:compileKotlinMetadata, which failed in this environment due to missing Supabase credentials required by the build configuration.

---

Codex Task

---

Perform an AI-assisted review on

[Copilot]

Pull request overview

This PR updates SmartInsightsTab so time-windowed insight calculations use a timestamp captured when data is fetched, aligning Smart Suggestions and readiness calculations with the latest refresh cycle.

Changes:

• Replaced the fixed remembered timestamp with mutable Compose state.
• Refreshed nowMs at the start of the profile-based fetch flow.
• Added nowMs to memoization keys for time-sensitive insight computations.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[gemini-code-assist]

Code Review

This pull request updates the SmartInsightsTab to refresh the current timestamp whenever the profile changes and ensures that dependent insights are recomputed by adding nowMs as a key to their respective remember blocks. A review comment suggests resetting the isLoading state when the profile changes to avoid displaying stale data and recommends using a local variable for the timestamp within the LaunchedEffect to ensure consistency during the data fetch.

[gemini-code-assist]

When profileId changes, isLoading should be reset to true at the start of the LaunchedEffect. Currently, if the user switches profiles, isLoading remains false (from the previous profile's state). The update to nowMs at line 120 will trigger a recomposition, causing insights to be recomputed using the new timestamp but stale sessionSummaries from the previous profile before the new data fetch completes. Using a local variable for the fetch also ensures consistency within the effect.

Suggested change

	nowMs = currentTimeMillis()
	withContext(Dispatchers.IO) {
	sessionSummaries =
	repository.getSessionSummariesSince(nowMs - twentyEightDaysMs, profileId)
	isLoading = true
	val freshNow = currentTimeMillis()
	nowMs = freshNow
	withContext(Dispatchers.IO) {
	sessionSummaries =
	repository.getSessionSummariesSince(freshNow - twentyEightDaysMs, profileId)

[kilo-code-bot]

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity	Count
CRITICAL	0
WARNING	1
SUGGESTION	0

Issue Details (click to expand)

WARNING

File	Line	Issue
shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/screen/SmartInsightsTab.kt	119	When profileId changes after the first load, this effect never flips isLoading back to true, so the screen keeps rendering the previous profile's data while the new fetch is in flight. With the new nowMs assignment that stale data is also recomputed against a fresh timestamp, which can briefly show incorrect weekly volume/readiness values for the wrong profile.

|

Files Reviewed (1 files)

• shared/src/commonMain/kotlin/com/devil/phoenixproject/presentation/screen/SmartInsightsTab.kt - 1 issues

---

_{Reviewed by nemotron-3-super-120b-a12b-20230311:free · 156,023 tokens}