Skip to content

feat: implement native Antigravity CLI adapter and bump version to 8.0.4#20

Merged
9thLevelSoftware merged 1 commit into
mainfrom
codex/redesign-legion-explore-and-map
May 27, 2026
Merged

feat: implement native Antigravity CLI adapter and bump version to 8.0.4#20
9thLevelSoftware merged 1 commit into
mainfrom
codex/redesign-legion-explore-and-map

Conversation

@9thLevelSoftware

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 27, 2026 22:10
@9thLevelSoftware 9thLevelSoftware merged commit 5d89b10 into main May 27, 2026
4 checks passed
@9thLevelSoftware 9thLevelSoftware deleted the codex/redesign-legion-explore-and-map branch May 27, 2026 22:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces native integration and support for the brand new Antigravity CLI (agy), the successor to Google Gemini CLI. It adds a comprehensive adapter configuration, updates the installer script to handle the new plugin surface, registers the runtime metadata, and updates relevant documentation, tests, and checklists. The review feedback highlights a potential TypeError in bin/install.js when accessing properties of pkg.author and pkg.repository without optional chaining, as well as a minor grammatical typo in docs/index.html.

Comment thread bin/install.js
Comment on lines +1261 to +1269
const manifest = {
name: "legion",
version: pkg.version,
description: pkg.description,
author: pkg.author.name || pkg.author,
repository: pkg.repository.url || pkg.repository,
keywords: pkg.keywords,
license: pkg.license
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Accessing nested properties of pkg.author and pkg.repository directly can cause a TypeError if these fields are undefined or null in package.json. Since Node.js 18+ is required, we should use optional chaining (?.) to safely access these properties and prevent potential installer crashes.

Suggested change
const manifest = {
name: "legion",
version: pkg.version,
description: pkg.description,
author: pkg.author.name || pkg.author,
repository: pkg.repository.url || pkg.repository,
keywords: pkg.keywords,
license: pkg.license
};
const manifest = {
name: "legion",
version: pkg.version,
description: pkg.description,
author: pkg.author?.name || pkg.author,
repository: pkg.repository?.url || pkg.repository,
keywords: pkg.keywords,
license: pkg.license
};

Comment thread docs/index.html
<div class="feature-card">
<h3>Parallel Waves</h3>
<p>Leverages Antigravity's native subagent spawn mechanics to execute coordinate parallel waves with filesystem-based result polling.</p>
</div>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase 'execute coordinate parallel waves' contains a grammatical typo. It should be updated to 'execute coordinated parallel waves' or 'coordinate parallel waves' for better readability.

                    <p>Leverages Antigravity's native subagent spawn mechanics to execute coordinated parallel waves with filesystem-based result polling.</p>

@kilo-code-bot

kilo-code-bot Bot commented May 27, 2026

Copy link
Copy Markdown

Code Review Roast 🔥

Verdict: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
🚨 critical 1
⚠️ warning 0
💡 suggestion 0
🤏 nitpick 0
Issue Details (click to expand)
File Line Roast
skills/workflow-common/SKILL.md 523-534 Division counts are stale — claiming Engineering has 7 agents when there are actually 9, Product has 3 when there are 4, Marketing has 8 when there are 4, Testing has 7 when there are 6, Support has 6 when there are 4, Specialized has 3 when there are 4. TOTAL_AGENTS = 52 is wrong; the actual count is 49.

🏆 Best part: The Antigravity CLI adapter implementation is clean and follows established patterns from other certified adapters. The plugin.json manifest structure and installation flow are well-thought-out.

💀 Worst part: The Division Constants table in skills/workflow-common/SKILL.md (lines 519-534) is a museum piece. It predates this PR and hasn't been updated to match reality.

📊 Overall: Like a restaurant menu where the prices changed but nobody told the kitchen — the code serves 49 agents but the docs still think it's running a buffet for 52.

Files Reviewed (15 files)
  • adapters/antigravity-cli.md - 0 issues (new file, well-formed)
  • bin/install.js - 0 issues (new case added correctly)
  • bin/runtime-metadata.js - 0 issues (runtime config added correctly)
  • skills/workflow-common/SKILL.md - 1 issue (stale division counts)
  • tests/installer-smoke.test.js - 0 issues (test updated correctly)
  • tests/adapter-conformance.test.js - 0 issues (updated to 12 adapters correctly)
  • Various doc files - 0 issues (version bumps and updates)

Fix these issues in Kilo Cloud


Reviewed by laguna-m.1-20260312:free · 2,262,947 tokens

@kilo-code-bot

kilo-code-bot Bot commented May 27, 2026

Copy link
Copy Markdown

Correction to previous review: Upon re-checking the diff, the Division Constants section (lines 519-534 in SKILL.md) was NOT modified in this PR. That stale data is pre-existing technical debt, not a regression. This PR is actually clean for its intended changes — adding Antigravity CLI support. I withdraw my previous criticism and recommend merge.

@9thLevelSoftware 9thLevelSoftware removed the request for review from Copilot May 27, 2026 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant