feat: implement native Antigravity CLI adapter and bump version to 8.0.4#20
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces native integration and support for the brand new Antigravity CLI (agy), the successor to Google Gemini CLI. It adds a comprehensive adapter configuration, updates the installer script to handle the new plugin surface, registers the runtime metadata, and updates relevant documentation, tests, and checklists. The review feedback highlights a potential TypeError in bin/install.js when accessing properties of pkg.author and pkg.repository without optional chaining, as well as a minor grammatical typo in docs/index.html.
| const manifest = { | ||
| name: "legion", | ||
| version: pkg.version, | ||
| description: pkg.description, | ||
| author: pkg.author.name || pkg.author, | ||
| repository: pkg.repository.url || pkg.repository, | ||
| keywords: pkg.keywords, | ||
| license: pkg.license | ||
| }; |
There was a problem hiding this comment.
Accessing nested properties of pkg.author and pkg.repository directly can cause a TypeError if these fields are undefined or null in package.json. Since Node.js 18+ is required, we should use optional chaining (?.) to safely access these properties and prevent potential installer crashes.
| const manifest = { | |
| name: "legion", | |
| version: pkg.version, | |
| description: pkg.description, | |
| author: pkg.author.name || pkg.author, | |
| repository: pkg.repository.url || pkg.repository, | |
| keywords: pkg.keywords, | |
| license: pkg.license | |
| }; | |
| const manifest = { | |
| name: "legion", | |
| version: pkg.version, | |
| description: pkg.description, | |
| author: pkg.author?.name || pkg.author, | |
| repository: pkg.repository?.url || pkg.repository, | |
| keywords: pkg.keywords, | |
| license: pkg.license | |
| }; |
| <div class="feature-card"> | ||
| <h3>Parallel Waves</h3> | ||
| <p>Leverages Antigravity's native subagent spawn mechanics to execute coordinate parallel waves with filesystem-based result polling.</p> | ||
| </div> |
There was a problem hiding this comment.
The phrase 'execute coordinate parallel waves' contains a grammatical typo. It should be updated to 'execute coordinated parallel waves' or 'coordinate parallel waves' for better readability.
<p>Leverages Antigravity's native subagent spawn mechanics to execute coordinated parallel waves with filesystem-based result polling.</p>
Code Review Roast 🔥Verdict: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)
🏆 Best part: The Antigravity CLI adapter implementation is clean and follows established patterns from other certified adapters. The plugin.json manifest structure and installation flow are well-thought-out. 💀 Worst part: The Division Constants table in 📊 Overall: Like a restaurant menu where the prices changed but nobody told the kitchen — the code serves 49 agents but the docs still think it's running a buffet for 52. Files Reviewed (15 files)
Fix these issues in Kilo Cloud Reviewed by laguna-m.1-20260312:free · 2,262,947 tokens |
|
Correction to previous review: Upon re-checking the diff, the Division Constants section (lines 519-534 in SKILL.md) was NOT modified in this PR. That stale data is pre-existing technical debt, not a regression. This PR is actually clean for its intended changes — adding Antigravity CLI support. I withdraw my previous criticism and recommend merge. |
No description provided.