Skip to content

fix: quote argument-hint YAML values so Copilot CLI ≥1.0.65 loads all skills (closes #22)#23

Open
thejesh23 wants to merge 1 commit into
9thLevelSoftware:mainfrom
thejesh23:fix/quote-argument-hint-yaml
Open

fix: quote argument-hint YAML values so Copilot CLI ≥1.0.65 loads all skills (closes #22)#23
thejesh23 wants to merge 1 commit into
9thLevelSoftware:mainfrom
thejesh23:fix/quote-argument-hint-yaml

Conversation

@thejesh23

Copy link
Copy Markdown

Closes #22.

Summary

Purely mechanical single-character transform to 5 file(s): wrap the value after argument-hint: in double quotes so YAML parses it as a string instead of a flow-sequence array. Fixes GitHub Copilot CLI ≥ 1.0.65 silently dropping the skill.

- argument-hint: [foo]
+ argument-hint: "[foo]"

Bare [...] is YAML flow-sequence syntax → the loader receives ["foo"] (a list), fails its str validation, and rejects the SKILL without an error. Claude Code, VS Code Agent Skills, and every other loader document argument-hint as a string; the quoted-string form is what all reference docs show.

Files (5)

  • commands/status.md
  • .planning/archive/05-quality-gates/05-02-PLAN.md
  • .planning/archive/04-parallel-execution/04-03-PLAN.md
  • docs/superpowers/plans/2026-05-06-code-polish.md
  • docs/superpowers/specs/2026-05-06-code-polish-design.md

Verification

  • YAML round-trip via yaml.safe_load on every changed frontmatter reports argument-hint as str
  • No vulnerable value contained " or \, so bare double-quote wrapping is safe

Sources

… skills

`argument-hint: [foo]` YAML-parses as a flow sequence (array), not a
string. Downstream slash-command loaders that validate `argument-hint`
as a string — notably GitHub Copilot CLI ≥ 1.0.65 — silently reject
the skill on load, and the command disappears from the CLI menu.

Wrap the value in double quotes so it parses as a string. No behaviour
change on Claude Code.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several markdown files, including plans, specifications, and command definitions, to wrap the values of the argument-hint fields in double quotes. I have no feedback to provide as there are no review comments and the changes are straightforward.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@kilo-code-bot

kilo-code-bot Bot commented Jul 13, 2026

Copy link
Copy Markdown

Code Review Roast 🔥

Verdict: No Issues Found | Recommendation: Merge

Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up for a "yaml-as-list silent-rejection" bug investigation and instead got five mechanical character swaps, a clear root-cause explanation in the body, and a one-line reproduction note in the commit message. This is what a senior engineer looks like at 9:13 AM on a Monday before coffee, and I am annoyed by how little there is to roast.

I did my due diligence: grepped the whole tree for ^argument-hint: \[ to make sure no other slash command is still feeding Copilot CLI a flow sequence. Nothing. commands/status.md was the last straggler. The other four changes are stale docs / archived plans showing the same template — defensible, not scope creep, because they're the canonical example of the format and were quietly lying to the next reader.

Ponytail: Lean already. Ship.

Ponytail net: 0 lines. (5 lines changed, all required; the patch is already the minimum.)

Correctness / Safety findings:
None. [--dry-run] parses to ["--dry-run"] (a list), which fails any sane str validator. Wrapping in "..." is the standard YAML idiom and the form every reference doc shows. None of the wrapped values contain " or \, so no escaping is needed.

Suggested minimal patch:
No patch needed.

Final merge guidance:
Can merge as-is.

📊 Overall: A one-character fix, five files, zero new abstractions, zero new dependencies, and a commit message that tells you exactly why. This is the Platonic ideal of a bug-fix PR — I'd frame it if I could.

Files Reviewed (5 files)
  • commands/status.md — real fix; unquoted [--dry-run] flow sequence. Now quoted. ✅
  • .planning/archive/04-parallel-execution/04-03-PLAN.md — stale example block. ✅
  • .planning/archive/05-quality-gates/05-02-PLAN.md — stale example block. ✅
  • docs/superpowers/plans/2026-05-06-code-polish.md — stale example block. ✅
  • docs/superpowers/specs/2026-05-06-code-polish-design.md — stale example block. ✅

Reviewed by minimax-m3 · Input: 29.1K · Output: 5.2K · Cached: 163.3K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skills fail to load in GitHub Copilot CLI ≥1.0.65 due to array-shaped argument-hint

1 participant