Skip to content

32bit fixes 20260423#83

Merged
MingcongBai merged 10 commits into
masterfrom
32bit-fixes-20260423
May 16, 2026
Merged

32bit fixes 20260423#83
MingcongBai merged 10 commits into
masterfrom
32bit-fixes-20260423

Conversation

@Cyanoxygen
Copy link
Copy Markdown
Member

@Cyanoxygen Cyanoxygen commented Apr 23, 2026

  • Add AB_FLAGS_ATOMIC switch to add -latomic to CFLAGS, CXXFLAGS and LDFLAGS.
  • Prepend CPPFLAGS to CFLAGS and CXXFLAGS for CMake as it does not process ENV{CPPFLAGS}.
  • Add AB_FLAGS_Y2038 switch to add -D_FILE_OFFSET_BITS=64 -D_TIME_BITS=64 to CPPFLAGS.

@Cyanoxygen Cyanoxygen force-pushed the 32bit-fixes-20260423 branch from a8781c5 to c9bfc9d Compare April 23, 2026 07:09
@Cyanoxygen
Copy link
Copy Markdown
Member Author

image

Tested good on i486.

image

No regression found on amd64.

@Cyanoxygen Cyanoxygen force-pushed the 32bit-fixes-20260423 branch 2 times, most recently from 186b566 to a862668 Compare April 23, 2026 07:39
@Cyanoxygen
Copy link
Copy Markdown
Member Author

Cyanoxygen commented Apr 23, 2026

image

CMake (cppdap) requires -latomic. This is when AB_FLAGS_ATOMIC__I486=1.

@Cyanoxygen
Copy link
Copy Markdown
Member Author

Hold please - current solution does not allow AB_FLAG_Y2038 overrides in the defines files. Some packages may have their own file64 and time64 handling, and should have the transparent LFS support disabled.

Cyanoxygen added 10 commits May 16, 2026 23:31
Adding this switch saves all ab_match_arch occurrences that manually
adds '-latomic' to compiler flags.
CMake does not add ENV{CPPFLAGS} to CMAKE_${LANGUAGE}_FLAGS_INIT. We must
either patch CMake or add CPPFLAGS to CFLAGS and CXXFLAGS manually.
Some defines file may override AB_FLAGS_* defined in an arch-specific
manner.

* Clarify the two defines file reads in comments.
Complements the change that adds FORTIFY_SOURCE to CPPFLAGS.
@Cyanoxygen Cyanoxygen force-pushed the 32bit-fixes-20260423 branch from a862668 to 5dfc099 Compare May 16, 2026 15:33
@Cyanoxygen
Copy link
Copy Markdown
Member Author

Tested on i486 with v4l-utils (with Y2038 override) and autobuild4 (default).

image image

@MingcongBai MingcongBai merged commit 211fec5 into master May 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants