Skip to content

If an Entity attribute for the group was not found, just continue #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomHAnderson merged 1 commit into from
Jan 14, 2026
Merged

If an Entity attribute for the group was not found, just continue #192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/Metadata/MetadataFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ public function __invoke(): ArrayObject
->getMetadataFactory()
->getMetadataFor($reflectionClass->getName());

$this->buildMetadataForEntity($reflectionClass);
// If an Entity attribute does not exist, skip this entity
if (! $this->buildMetadataForEntity($reflectionClass)) {
continue;
}

$this->buildMetadataForFields($entityClassMetadata, $reflectionClass);
$this->buildMetadataForAssociations($reflectionClass);
}
Expand All @@ -82,9 +86,10 @@ public function __invoke(): ArrayObject
* The buildmetadata* functions exist to simplify the buildMetadata
* function.
*/
private function buildMetadataForEntity(ReflectionClass $reflectionClass): void
private function buildMetadataForEntity(ReflectionClass $reflectionClass): bool
{
$entityInstance = null;
$entityInstance = null;
$entityAttributeFound = false;

// Fetch attributes for the entity class filterd by Attribute\Entity
foreach ($reflectionClass->getAttributes(Attribute\Entity::class) as $attribute) {
Expand All @@ -95,6 +100,8 @@ private function buildMetadataForEntity(ReflectionClass $reflectionClass): void
continue;
}

$entityAttributeFound = true;

// Only one matching instance per group is allowed
assert(
! $entityInstance,
Expand All @@ -116,6 +123,8 @@ private function buildMetadataForEntity(ReflectionClass $reflectionClass): void
$this->getTypeName($reflectionClass->getName()),
];
}

return $entityAttributeFound;
}

/**
Expand Down
Loading