Repository navigation
Clear the test projects' NuGet warnings - #2117
Merged
Merged
Conversation
InteractiveWrapperUnitTests restored with twelve NU1903 and one NU1902: Microsoft.DotNet.Interactive.FSharp brings System.Security.Cryptography.Xml and .Pkcs 9.0.6, the chain AngouriMath.Terminal.Lib already pins to 9.0.21 (#797). The same pin here pulls both forward, Pkcs through Xml. Both test projects also printed the NU1608 for FSharp.Compiler.Service 43.9.300 beside FSharp.Core 10.1, which #1132 measured as benign and suppressed in the shipped Terminal projects, moving the claim into CompilerServiceWorksTest. NoWarn does not flow to a referencing project, so the test projects get the same suppression, pointing at that test. Restoring every project on Linux, 34 of 36 now print no NuGet warning. The other two are the Windows samples, which need Windows targeting; with it they print only NU1701, for SkiaSharp.Views.WindowsForms and OpenTK through ScottPlot.WinForms, whose newest release still depends on them. TerminalUnitTests pass 67 of 67, InteractiveWrapperUnitTests 19 with 1 skipped. Part of #542 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #542. The last NuGet warnings outside the Windows samples, both in test projects.
InteractiveWrapperUnitTests:System.Security.Cryptography.Xml/.Pkcs9.0.6 throughMicrosoft.DotNet.Interactive.FSharpAngouriMath.Terminal.Libis (#797)NU1608, FSharp.Compiler.Service 43.9.300 beside FSharp.Core 10.1, in both test projectsCompilerServiceWorksTestcarries the checkTerminalUnitTestsInteractiveWrapperUnitTestsThe other two are
AngouriMathPlotandGraphicExample, which restore only with Windows targeting and then printNU1701forSkiaSharp.Views.WindowsForms3.119.0 and OpenTK 3.1.0, throughScottPlot.WinForms. Its newest release, 5.1.59, still depends on them, so they are left.Found on the way and left as it is:
<PackageReference Update="FSharp.Compiler.Service" Version="43.10.101" />inInteractiveWrapperUnitTests(#640) does not take effect, becauseUpdateapplies only to a reference the project already has andFSharp.Compiler.Servicearrives transitively. 43.9.300 is what resolves.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura