Repository navigation
Project coverage may move within a percent before its status fails - #2172
Merged
Merged
Conversation
With no threshold, codecov/project fails on any fall at all from the base commit's figure. Now that reports reach Codecov (#2162, #2165), that turns ordinary changes red: #2171 was at -0.02%, five lines that a new guard returns before. A threshold of 1% lets that movement through and still fails what the status is for, such as a test leg whose report goes empty, which moved the figure from 86.41% to 0.38%. Codecov's validator accepts the file and reads the threshold back as 1.0. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2172 +/- ##
==========================================
- Coverage 86.42% 86.41% -0.01%
==========================================
Files 295 295
Lines 64808 64808
Branches 19060 19060
==========================================
- Hits 56011 56007 -4
- Misses 4767 4771 +4
Partials 4030 4030
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With no threshold,
codecov/projectfails on any fall at all from the base commit's figure. Now that reports reach Codecov (#2162, #2165), that turns ordinary changes red: #2171 was red at −0.02%, five lines that a new guard returns before.A threshold of 1% lets that movement through. It still fails what the status is for, such as a test leg whose report goes empty, which moved the figure from 86.41% to 0.38% before #2165.
Codecov's validator accepts the file and reads the threshold back as
1.0.patchandchangesstay off, as before.🤖 Generated with Claude Code
https://claude.ai/code/session_012sonx8iAspMiwRwokT1Ura