rework display state system to be extensible#5
Merged
segallagher merged 7 commits intomainfrom Apr 14, 2026
Merged
Conversation
|
|
bbuechler
reviewed
Apr 14, 2026
Comment on lines
+38
to
+44
| // const updateReposBtn = new ToolbarButton({ | ||
| // className: 'nbgitpuller-jl-interface-update-btn', | ||
| // label: '◉ Initializing', | ||
| // tooltip: 'Initializing nbgitpuller' | ||
| // }); | ||
| // updateReposBtn.id = widget_id; | ||
| // updateReposBtn.addClass('nbgitpuller-jl-interface-wrapper'); |
There was a problem hiding this comment.
Is there reason to retain this code block?
dgpalmieri
approved these changes
Apr 14, 2026
| import { JupyterFrontEnd } from '@jupyterlab/application'; | ||
|
|
||
| import { ToolbarButton } from '@jupyterlab/apputils'; | ||
| // import { ToolbarButton } from '@jupyterlab/apputils'; |
Member
There was a problem hiding this comment.
Suggested change
| // import { ToolbarButton } from '@jupyterlab/apputils'; |
Comment on lines
+38
to
+44
| // const updateReposBtn = new ToolbarButton({ | ||
| // className: 'nbgitpuller-jl-interface-update-btn', | ||
| // label: '◉ Initializing', | ||
| // tooltip: 'Initializing nbgitpuller' | ||
| // }); | ||
| // updateReposBtn.id = widget_id; | ||
| // updateReposBtn.addClass('nbgitpuller-jl-interface-wrapper'); |
Member
There was a problem hiding this comment.
Suggested change
| // const updateReposBtn = new ToolbarButton({ | |
| // className: 'nbgitpuller-jl-interface-update-btn', | |
| // label: '◉ Initializing', | |
| // tooltip: 'Initializing nbgitpuller' | |
| // }); | |
| // updateReposBtn.id = widget_id; | |
| // updateReposBtn.addClass('nbgitpuller-jl-interface-wrapper'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rework display state system to be extensible
fully take over creation of widget
stop adding an event listener every time the widget status is updated
split error and pending states to be red and orange respectively