Skip to content

Fix nullable, required fields #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hipstersmoothie merged 1 commit into from
Jul 7, 2026
Merged

Fix nullable, required fields #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions lexicons/fyi/atstore/directory/getListing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
"reviewCount",
"priceLabel",
"appTags",
"categorySlugs"
"categorySlugs",
"iconUrl",
"heroImageUrl",
"categorySlug",
"rating",
"productAccountHandle"
],
"nullable": [
"iconUrl",
Expand Down Expand Up @@ -78,7 +83,18 @@
},
"listingDetailResponse": {
"type": "object",
"required": ["listing", "isStoreManaged"],
"required": [
"listing",
"isStoreManaged",
"repoDid",
"productAccountDid",
"sourceTagline",
"sourceFullDescription",
"externalUrl",
"sourceUrl",
"createdAt",
"updatedAt"
],
"nullable": [
"repoDid",
"productAccountDid",
Expand Down
7 changes: 6 additions & 1 deletion lexicons/fyi/atstore/directory/searchListings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,12 @@
"reviewCount",
"priceLabel",
"appTags",
"categorySlugs"
"categorySlugs",
"iconUrl",
"heroImageUrl",
"categorySlug",
"rating",
"productAccountHandle"
],
"nullable": [
"iconUrl",
Expand Down
6 changes: 5 additions & 1 deletion lexicons/fyi/atstore/reviews/listForListing.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,11 @@
"rating",
"reviewCreatedAt",
"replyCount",
"canReply"
"canReply",
"text",
"authorDisplayName",
"authorHandle",
"authorAvatarUrl"
],
"nullable": [
"text",
Expand Down
32 changes: 27 additions & 5 deletions src/lexicons/generated/bundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export const lexicons = [
"main": {
"type": "permission-set",
"title": "Submit AT Store reviews",
"detail": "Create fyi.atstore.profile/self when needed and fyi.atstore.listing.review records on the user's PDS via repository APIs; read public directory data via XRPC queries.",
"detail": "Create reviews on AT Store listings",
"permissions": [
{
"type": "permission",
Expand Down Expand Up @@ -79,7 +79,12 @@ export const lexicons = [
"reviewCount",
"priceLabel",
"appTags",
"categorySlugs"
"categorySlugs",
"iconUrl",
"heroImageUrl",
"categorySlug",
"rating",
"productAccountHandle"
],
"nullable": [
"iconUrl",
Expand Down Expand Up @@ -184,7 +189,15 @@ export const lexicons = [
"type": "object",
"required": [
"listing",
"isStoreManaged"
"isStoreManaged",
"repoDid",
"productAccountDid",
"sourceTagline",
"sourceFullDescription",
"externalUrl",
"sourceUrl",
"createdAt",
"updatedAt"
],
"nullable": [
"repoDid",
Expand Down Expand Up @@ -308,7 +321,12 @@ export const lexicons = [
"reviewCount",
"priceLabel",
"appTags",
"categorySlugs"
"categorySlugs",
"iconUrl",
"heroImageUrl",
"categorySlug",
"rating",
"productAccountHandle"
],
"nullable": [
"iconUrl",
Expand Down Expand Up @@ -782,7 +800,11 @@ export const lexicons = [
"rating",
"reviewCreatedAt",
"replyCount",
"canReply"
"canReply",
"text",
"authorDisplayName",
"authorHandle",
"authorAvatarUrl"
],
"nullable": [
"text",
Expand Down
Loading