Skip to content
This repository was archived by the owner on Apr 9, 2022. It is now read-only.

Adding a few more tests#3

Merged
Chocrates merged 23 commits into
masterfrom
tests
Mar 5, 2020
Merged

Adding a few more tests#3
Chocrates merged 23 commits into
masterfrom
tests

Conversation

@Chocrates
Copy link
Copy Markdown
Contributor

Finally got off my butt and finished some tests.
Closes #1

Comment thread .npmrc
@@ -0,0 +1 @@
@chocrates:registry=https://npm.pkg.github.com/ No newline at end of file
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Chocrates Looks like there is an issue authenticating with the package registry.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect that a GITHUB_TOKEN is needed to install the npm package from the registry given this article but I haven’t seen anything on how to do that.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Zack. I know I had to generate a token to publish but Im surprised id need one to pull too. Ill see what I can figure out

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zkoppert took me 23 tries but I got the build to work.
Test is never going to work, see #2
Not sure what to do there.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Nice!

@Chocrates Chocrates merged commit 314a560 into master Mar 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Complete tests

2 participants