fix: rename predicate functions per no-Is/Has/Can convention

Rename isConsumerLayer → consumerLayer in cross_package_types_test.go
and isSyncableTool → syncableTool in steering/{format,sync}.go.
isNumeric was already removed during earlier migrations.

Persist session decisions and learnings.

Spec: specs/ast-audit-contributor-guide.md
Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

.context/DECISIONS.md

@@ -3,6 +3,8 @@
 <!-- INDEX:START -->
 | Date | Decision |
 |----|--------|
+| 2026-04-04 | TestNoMagicStrings and TestNoMagicValues no longer exempt const/var definitions outside config/ |
+| 2026-04-04 | String-typed enums belong in config/, not domain packages |
 | 2026-04-03 | Output functions belong in write/ (consolidated) |
 | 2026-04-03 | YAML text externalization pipeline (consolidated) |
 | 2026-04-03 | Package taxonomy and code placement (consolidated) |
@@ -114,6 +116,34 @@ For significant decisions:
 
 -->
 
+## [2026-04-04-025755] TestNoMagicStrings and TestNoMagicValues no longer exempt const/var definitions outside config/
+
+**Status**: Accepted
+
+**Context**: The isConstDef/isVarDef blanket exemption masked 156+ string and 7 numeric constants in the wrong package
+
+**Decision**: TestNoMagicStrings and TestNoMagicValues no longer exempt const/var definitions outside config/
+
+**Rationale**: Const definitions outside config/ are magic values in the wrong place — naming them does not fix the structural problem
+
+**Consequence**: All new code with string/numeric constants outside config/ fails these tests immediately
+
+---
+
+## [2026-04-04-025746] String-typed enums belong in config/, not domain packages
+
+**Status**: Accepted
+
+**Context**: Debated whether type IssueType string with const values belongs in domain or config. The string value is the same regardless of type annotation.
+
+**Decision**: String-typed enums belong in config/, not domain packages
+
+**Rationale**: Types without behavior belong in config. Promote to entity/ only when methods/interfaces appear.
+
+**Consequence**: All type Foo string + const blocks outside config/ are now caught by TestNoMagicStrings.
+
+---
+
 ## [2026-04-03-180000] Output functions belong in write/ (consolidated)
 
 **Status**: Accepted

.context/LEARNINGS.md

@@ -17,6 +17,8 @@ DO NOT UPDATE FOR:
 <!-- INDEX:START -->
 | Date | Learning |
 |----|--------|
+| 2026-04-04 | Format-verb strings are localizable text, not exempt from magic string checks |
+| 2026-04-04 | Agents add allowlist entries to make tests pass — guard every exemption |
 | 2026-04-03 | Subagent scope creep and cleanup (consolidated) |
 | 2026-04-03 | Bulk rename and replace_all hazards (consolidated) |
 | 2026-04-03 | Import cycles and package splits (consolidated) |
@@ -106,6 +108,26 @@ DO NOT UPDATE FOR:
 
 ---
 
+## [2026-04-04-025813] Format-verb strings are localizable text, not exempt from magic string checks
+
+**Context**: Strings like '%d entries checked' were passing TestNoMagicStrings because the format-verb exemption was too broad
+
+**Lesson**: Any string containing English words alongside format directives is user-facing text that belongs in YAML assets
+
+**Application**: Removed format-verb, URL-scheme, HTML-entity, and err/ exemptions from TestNoMagicStrings
+
+---
+
+## [2026-04-04-025805] Agents add allowlist entries to make tests pass — guard every exemption
+
+**Context**: Found that every exemption map/allowlist in audit tests is a tempting shortcut for agents
+
+**Lesson**: Added DO NOT widen guard comments to all 10 exemption data structures across 7 test files
+
+**Application**: Every new audit test with an exemption must include the guard comment. Review PRs for drive-by allowlist additions.
+
+---
+
 ## [2026-04-03-180000] Subagent scope creep and cleanup (consolidated)
 
 **Consolidated from**: 4 entries (2026-03-06 to 2026-03-23)

internal/audit/cross_package_types_test.go

@@ -205,10 +205,10 @@ func sameModule(a, b string) bool {
 	}
 	// cli/* consuming any domain module is the
 	// standard consumer layer pattern.
-	if isConsumerLayer(ma) && !isConsumerLayer(mb) {
+	if consumerLayer(ma) && !consumerLayer(mb) {
 		return true
 	}
-	if isConsumerLayer(mb) && !isConsumerLayer(ma) {
+	if consumerLayer(mb) && !consumerLayer(ma) {
 		return true
 	}
 	// err/<X> consumed from cli/<X> or <X>.
@@ -278,8 +278,8 @@ func moduleRoot(pkgPath string) string {
 	return parts[0]
 }
 
-// isConsumerLayer returns true if the module root is a
+// consumerLayer returns true if the module root is a
 // consumer layer that naturally imports domain types.
-func isConsumerLayer(mod string) bool {
+func consumerLayer(mod string) bool {
 	return strings.HasPrefix(mod, "cli/")
 }

internal/steering/format.go

@@ -22,8 +22,8 @@ import (
 	ctxIo "github.com/ActiveMemory/ctx/internal/io"
 )
 
-// isSyncableTool returns true if the tool supports native-format sync.
-func isSyncableTool(tool string) bool {
+// syncableTool returns true if the tool supports native-format sync.
+func syncableTool(tool string) bool {
 	for _, t := range syncableTools {
 		if t == tool {
 			return true

internal/steering/sync.go

@@ -36,7 +36,7 @@ var syncableTools = []string{
 func SyncTool(
 	steeringDir, projectRoot, tool string,
 ) (SyncReport, error) {
-	if !isSyncableTool(tool) {
+	if !syncableTool(tool) {
 		supported := strings.Join(
 			syncableTools, token.CommaSpace,
 		)
@@ -116,7 +116,7 @@ func SyncAll(
 // Returns nil if no stale files are found or if the steering
 // directory cannot be read.
 func StaleFiles(steeringDir, projectRoot, tool string) []string {
-	if !isSyncableTool(tool) {
+	if !syncableTool(tool) {
 		return nil
 	}