fix: eliminate testOnlyExports, teach dead-export scanner cross-package test usage

Remove the testOnlyExports allowlist entirely. Instead, add Phase
2.5 to TestNoDeadExports that loads packages with Tests: true and
removes symbols used cross-package in test files. A symbol imported
by a test in a different package is test infrastructure, not dead.

Also fix parser.findParser → parser.find (stuttery name) and move
to tools.go (mixed visibility).

Spec: specs/ast-audit-contributor-guide.md
Signed-off-by: Jose Alekhinne <jose@ctx.ist>

Author: josealekhine

internal/audit/dead_exports_test.go

@@ -26,29 +26,6 @@ import (
 // internal and may be used via reflection or are
 // genuinely file-scoped helpers.
 
-// DO NOT add entries here to make tests pass. New code must
-// conform to the check. Widening requires a dedicated PR with
-// justification for each entry.
-//
-// testOnlyExports lists exported symbols that exist
-// solely for test usage. The dead-export scanner skips
-// test files, so these would otherwise be false
-// positives. Keep this list small: prefer eliminating
-// the export over adding it here.
-var testOnlyExports = map[string]bool{
-	"github.com/ActiveMemory/ctx/internal/config/hook.CategoryCustomizable":    true,
-	"github.com/ActiveMemory/ctx/internal/assets/hooks/messages.Hooks":         true,
-	"github.com/ActiveMemory/ctx/internal/cli/pad/core/store.EnsureGitignore":  true,
-	"github.com/ActiveMemory/ctx/internal/cli/system/core/state.SetDirForTest": true,
-	"github.com/ActiveMemory/ctx/internal/config/asset.DirReferences":          true,
-	"github.com/ActiveMemory/ctx/internal/config/regex.Phase":                  true,
-	"github.com/ActiveMemory/ctx/internal/inspect.StartsWithCtxMarker":         true,
-	"github.com/ActiveMemory/ctx/internal/journal/parser.Parser":               true,
-	"github.com/ActiveMemory/ctx/internal/mcp/proto.InitializeParams":          true,
-	"github.com/ActiveMemory/ctx/internal/mcp/proto.UnsubscribeParams":         true,
-	"github.com/ActiveMemory/ctx/internal/rc.Reset":                            true,
-}
-
 // DO NOT add entries here to make tests pass. New code must
 // conform to the check. Widening requires a dedicated PR with
 // justification for each entry.
@@ -148,9 +125,30 @@ func TestNoDeadExports(t *testing.T) {
 		}
 	}
 
-	// Phase 3: remove test-only allowlist entries.
-	for key := range testOnlyExports {
-		delete(defs, key)
+	// Phase 2.5: remove symbols used cross-package in
+	// test files. If a test in package B imports a
+	// symbol from package A, the symbol is test
+	// infrastructure — not dead. Same-package test
+	// usage does not count (those should be unexported).
+	testPkgs := loadTestPackages(t)
+	for _, pkg := range testPkgs {
+		for ident, obj := range pkg.TypesInfo.Uses {
+			if obj == nil || obj.Pkg() == nil {
+				continue
+			}
+			pos := pkg.Fset.Position(ident.Pos())
+			if !isTestFile(pos.Filename) {
+				continue
+			}
+			// Cross-package: the test's package path
+			// differs from the symbol's defining package.
+			if pkg.PkgPath == obj.Pkg().Path() {
+				continue
+			}
+			key := obj.Pkg().Path() + "." +
+				obj.Name()
+			delete(defs, key)
+		}
 	}
 
 	// Phase 3b: remove Linux-only exports (used from
@@ -212,6 +210,30 @@ func loadCmdPackages(t *testing.T) []*packages.Package {
 	return pkgs
 }
 
+// loadTestPackages loads internal/ packages WITH test
+// files for cross-package test usage detection.
+func loadTestPackages(
+	t *testing.T,
+) []*packages.Package {
+	t.Helper()
+	cfg := &packages.Config{
+		Mode: packages.NeedName |
+			packages.NeedFiles |
+			packages.NeedSyntax |
+			packages.NeedTypes |
+			packages.NeedTypesInfo,
+		Tests: true,
+	}
+	pkgs, loadErr := packages.Load(
+		cfg,
+		"github.com/ActiveMemory/ctx/internal/...",
+	)
+	if loadErr != nil {
+		t.Fatalf("packages.Load tests: %v", loadErr)
+	}
+	return pkgs
+}
+
 // isExported reports whether name starts with an
 // uppercase letter.
 func isExported(name string) bool {

internal/journal/parser/markdown_test.go

@@ -422,7 +422,7 @@ func TestRegisteredTools_IncludesMarkdown(t *testing.T) {
 }
 
 func TestGetParser_Markdown(t *testing.T) {
-	p := Parser(session.ToolMarkdown)
+	p := find(session.ToolMarkdown)
 	if p == nil {
 		t.Fatalf("expected parser for %q", session.ToolMarkdown)
 	}

internal/journal/parser/parser.go

@@ -194,19 +194,3 @@ func FindSessionsForCWD(
 		return s.CWD == cwd
 	}, additionalDirs...)
 }
-
-// Parser returns a parser for the specified tool.
-//
-// Parameters:
-//   - tool: Tool identifier (e.g., "claude-code")
-//
-// Returns:
-//   - Session: The parser for the tool, or nil if not found
-func Parser(tool string) Session {
-	for _, p := range registeredParsers {
-		if p.Tool() == tool {
-			return p
-		}
-	}
-	return nil
-}

internal/journal/parser/parser_test.go

@@ -340,15 +340,15 @@ func TestRegisteredTools(t *testing.T) {
 }
 
 func TestGetParser(t *testing.T) {
-	parser := Parser("claude-code")
+	parser := find("claude-code")
 	if parser == nil {
 		t.Error("expected parser for 'claude-code'")
 	}
 	if parser.Tool() != "claude-code" {
 		t.Errorf("expected tool 'claude-code', got '%s'", parser.Tool())
 	}
 
-	unknown := Parser("unknown-tool")
+	unknown := find("unknown-tool")
 	if unknown != nil {
 		t.Error("expected nil for unknown tool")
 	}

internal/journal/parser/tools.go

@@ -6,6 +6,22 @@
 
 package parser
 
+// find returns a parser for the specified tool.
+//
+// Parameters:
+//   - tool: Tool identifier (e.g., "claude-code")
+//
+// Returns:
+//   - Session: The parser, or nil if not found
+func find(tool string) Session {
+	for _, p := range registeredParsers {
+		if p.Tool() == tool {
+			return p
+		}
+	}
+	return nil
+}
+
 // registeredTools returns the list of supported tools.
 //
 // Returns:

internal/rc/rc.go

@@ -441,8 +441,8 @@ func OverrideContextDir(ctxDir string) {
 	rcOverrideDir = ctxDir
 }
 
-// Reset clears the cached configuration, forcing reload on the next access.
-// This is primarily useful for testing.
+// Reset clears the cached configuration, forcing
+// reload on the next access.
 func Reset() {
 	rcMu.Lock()
 	defer rcMu.Unlock()