Earth - Christina#23
Open
christinaminh wants to merge 5 commits into
Open
Conversation
CheezItMan
reviewed
Mar 25, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Well done Christina, you hit the learning goals here. Nice work!
Comment on lines
21
to
23
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+24
to
+29
| if @head | ||
| new_node = Node.new(value, @head) | ||
| @head = new_node | ||
| else | ||
| @head = Node.new(value) | ||
| end |
There was a problem hiding this comment.
This is a little simpler.
Suggested change
| if @head | |
| new_node = Node.new(value, @head) | |
| @head = new_node | |
| else | |
| @head = Node.new(value) | |
| end | |
| @head = Node.new(value, @head) |
Comment on lines
34
to
36
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
54
to
56
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_max |
Comment on lines
75
to
77
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
221
to
223
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last |
Comment on lines
237
to
239
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_middle_value |
There was a problem hiding this comment.
👍 , good use of fast & slow references.
Comment on lines
258
to
260
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_nth_from_end(n) |
There was a problem hiding this comment.
👍 , I like the trailing reference which is n elements behind current.
Comment on lines
288
to
290
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def has_cycle |
Comment on lines
313
to
315
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def insert_ascending(value) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.