Skip to content

Earth/Taylor#37

Open
TaylorMililani wants to merge 3 commits into
Ada-C14:masterfrom
TaylorMililani:master
Open

Earth/Taylor#37
TaylorMililani wants to merge 3 commits into
Ada-C14:masterfrom
TaylorMililani:master

Conversation

@TaylorMililani

Copy link
Copy Markdown

No description provided.

@CheezItMan CheezItMan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Taylor, you hit the learning goals here. Well done. I did make some notes on space/time complexity and I'd like you to take a look at that.

Comment thread lib/linked_list.rb
Comment on lines +21 to 23
# Time Complexity: O(1)
# Space Complexity: O(1)
def add_first(value)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/linked_list.rb
Comment on lines +30 to 32
# Time Complexity: O(n)
# Space Complexity: O(n)
def search(value)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +46 to 48
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_max

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +64 to 66
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_min

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +84 to 86
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment thread lib/linked_list.rb
Comment on lines +193 to 195
# Time Complexity: O(n)
# Space Complexity: O(n)
def get_last

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +207 to 209
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_middle_value

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +226 to 228
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_nth_from_end(n)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +247 to 249
# Time Complexity: O(n)
# Space Complexity: O(n)
def has_cycle

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment thread lib/linked_list.rb
Comment on lines +264 to 266
# Time Complexity: O(n)
# Space Complexity: O(n)
def insert_ascending(value)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants