forked from lance-format/lance-graph
-
Notifications
You must be signed in to change notification settings - Fork 0
S3 IN-leg driver — version tick → owner forward-arc advance (no-op suppressed) #579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When callers use
drive_scheduled_tickwithExecTarget::Jit,SurrealQl, orElixir,scheduler.on_version(...)stamps that backend onto the proposedKanbanMove, but this RPC sends onlyproposed.toand returns the owner-generated move instead. The current owner implementations hard-codeExecTarget::Native, so the scheduled move is reported/routed as Native even though the scheduler selected a different backend.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in
fd1d58ff.drive_scheduled_ticknow keeps the owner's emitted move (authoritative phase transition, witness position, libet anchor — from the real mutation) but overlaysproposed.exec, so aJit/SurrealQl/Elixirselection survives instead of being flattened to the owner'sNativedefault. Regression testscheduled_tick_preserves_non_native_exec_targetasserts all three non-Native targets round-trip (13 tests green, clippy + fmt clean).(Note: the atomic
drive_version_tick/Tickpath is unaffected — it has no scheduler choosing a backend, so the owner'sNativeis correct there.)Generated by Claude Code