test(symbiont): run-NaN cognitive half proven green + fix ogar_codebook drift

[AdaWorldAPI]

What

Proves the cognitive half of the run-NaN hypothesis that #580 explicitly handed to the cognitive-compilation session (the actor-side half was proven there), and fixes a workspace-wide build blocker found en route.

1. Run-NaN census (the #580 deliverable)

run_nan_census_live_cycle_is_zero_at_scale in symbiont::kanban_loop drives the full Rubicon forward arc — including the BF16 Domino sweep burned through CognitiveWork — over a 4096-row SoA, then censuses the energy column:

• 0% NaN, 0% Inf, with non-trivial finite energy (not a no-op).
• The phase/i4 path is integer-only and the sweep is NaN-projection-guarded, so a live-cycle census reads clean.

cargo test --manifest-path crates/symbiont kanban_loop → 4/4 passed. The cognitive half is green.

2. Fix: ogar_codebook mirror drift (the blocker)

The symbiont build (and cognitive-stack) failed at the lance-graph-ogar const parity guard: OGAR main advanced class_ids::ALL 32 → 39 (added the 0x09XX Health domain — patient/diagnosis/lab_value/medication/treatment/visit/vital_sign, the MedCare/OGIT promotion) but the contract's wire mirror ogar_codebook::CODEBOOK was stale at 32.

The mirror was already prepped for health (ConceptDomain::Health, the 0x09 => Health map, the 0x0901 == Health test) — only the 7 CODEBOOK entries were missing. Synced them verbatim (stable ids); contract codebook tests green, CODEBOOK.len() == 39 == class_ids::ALL.len(). This unblocks symbiont + cognitive-stack workspace-wide (the golden image builds against current OGAR main again).

Coordination note for the OGAR session: the const guard is the lockstep discipline — keep the contract mirror synced when advancing class_ids::ALL.

Board: AGENT_LOG cont.³⁶.

🤖 Generated with Claude Code

---

Generated by Claude Code

Summary by CodeRabbit

• New Features

  • Added Health domain support with patient, diagnosis, lab value, medication, treatment, visit, and vital sign mappings.

• Bug Fixes

  • Resolved data synchronization parity issue affecting system stability.

• Tests

  • Added comprehensive validation test ensuring data integrity and reliability at scale.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[coderabbitai]

📝 Walkthrough

Walkthrough

Adds seven Health-domain (0x09XX) canonical concept mappings to ogar_codebook::CODEBOOK to match the expanded class_ids::ALL (32→39 entries). Adds a unit test in kanban_loop.rs that drives a 4096-row SymbiontBoard to the absorbing Commit phase and asserts zero NaN/Inf in the energy() column with at least one non-zero finite value. An agent log entry documents both changes.

Changes

Codebook Parity Fix and Energy Validation

Layer / File(s)	Summary
Health-domain CODEBOOK entries crates/lance-graph-contract/src/ogar_codebook.rs, .claude/board/AGENT_LOG.md	Adds wire-stable u16 mappings patient→vital_sign (0x0901–0x0907) to the CODEBOOK constant, syncing it with the expanded class_ids::ALL; the agent log records the parity-guard fix and build unblock.
Live-cycle NaN census test crates/symbiont/src/kanban_loop.rs	Adds run_nan_census_live_cycle_is_zero_at_scale: drives a 4096-row board through run_to_absorbing, then asserts 0 NaN, 0 Inf, and at least one non-zero finite entry in energy().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Poem

🐇 Seven new concepts hop into the book,
Health IDs in order — come take a look!
Patient and vital sign, diagnosis too,
The census reports: no NaN in the queue.
The build goes green, the rabbit cheers loud,
Finite energy blooms from the absorbing cloud! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly corresponds to the two main changes: adding a test proving the run-NaN hypothesis and fixing ogar_codebook drift that was a build blocker.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

crates/lance-graph-contract/src/ogar_codebook.rs (1)

141-148: ⚡ Quick win

Health-domain entries are correctly positioned and sequenced.

The seven Health-domain CODEBOOK entries (0x0901–0x0907) are syntactically sound and follow the established pattern. The sequential IDs, domain-qualified comment, and concept names are consistent with the codebook contract.

To strengthen test coverage, consider adding a Health-domain entry (e.g., "patient") to the spot-check assertions in codebook_ids_match_ogar_vocab (line 265–275). This would document parity and catch drift early without requiring a separate test.

📋 Suggested test enhancement

     #[test]
     fn codebook_ids_match_ogar_vocab() {
         // Drift guard: these MUST match OGAR `ogar_vocab::CODEBOOK` exactly (the
         // wire is the contract). If OGAR moves an id, update BOTH sides together.
         assert_eq!(canonical_concept_id("project"), Some(0x0101));
         assert_eq!(canonical_concept_id("project_work_item"), Some(0x0102));
         assert_eq!(canonical_concept_id("project_enabled_module"), Some(0x011A));
         assert_eq!(canonical_concept_id("commercial_line_item"), Some(0x0201));
         assert_eq!(canonical_concept_id("commercial_document"), Some(0x0202));
         assert_eq!(canonical_concept_id("currency_policy"), Some(0x0206));
+        assert_eq!(canonical_concept_id("patient"), Some(0x0901));
+        assert_eq!(canonical_concept_id("vital_sign"), Some(0x0907));
         assert_eq!(canonical_concept_id("not_a_concept"), None);
     }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/lance-graph-contract/src/ogar_codebook.rs` around lines 141 - 148, To
strengthen test coverage for the Health-domain codebook entries, locate the
spot-check assertions in the codebook_ids_match_ogar_vocab test function (around
lines 265-275) and add assertions for at least one Health-domain entry from the
newly added codes (0x0901-0x0907), such as verifying that "patient" maps to code
0x0901. This will document parity between the codebook and OGAR vocabulary for
the Health domain and help catch any future drift in these mappings.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@crates/lance-graph-contract/src/ogar_codebook.rs`:
- Around line 141-148: To strengthen test coverage for the Health-domain
codebook entries, locate the spot-check assertions in the
codebook_ids_match_ogar_vocab test function (around lines 265-275) and add
assertions for at least one Health-domain entry from the newly added codes
(0x0901-0x0907), such as verifying that "patient" maps to code 0x0901. This will
document parity between the codebook and OGAR vocabulary for the Health domain
and help catch any future drift in these mappings.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d9101e8-ef5b-4251-8d8f-eca071eb07ec

📥 Commits

Reviewing files that changed from the base of the PR and between 52edeb0 and d75f53b.

📒 Files selected for processing (3)

• .claude/board/AGENT_LOG.md
• crates/lance-graph-contract/src/ogar_codebook.rs
• crates/symbiont/src/kanban_loop.rs