Skip to content

fix(conformance): repoint MedcareBridge import after #585 OGIT/OGAR split#586

Merged
AdaWorldAPI merged 1 commit into
mainfrom
claude/fix-585-conformance-drift
Jun 21, 2026
Merged

fix(conformance): repoint MedcareBridge import after #585 OGIT/OGAR split#586
AdaWorldAPI merged 1 commit into
mainfrom
claude/fix-585-conformance-drift

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

Drift from #585

#585 ("move OGAR port bridges to lance-graph-ogar — restore OGIT/OGAR SoC") relocated the OGAR-driven bridges out of lance-graph-ontology but missed one consumer. lance-graph-consumer-conformance still imports:

// crates/lance-graph-consumer-conformance/src/lib.rs:93
use lance_graph_ontology::bridges::MedcareBridge;  // ← moved to lance_graph_ogar in #585

Since MedcareBridge (and its HealthcarePort) now live in lance-graph-ogar, this is a hard compile break in the conformance CI gate.

Fix

The identical transformation #585 applied to every other consumer:

  1. use lance_graph_ontology::bridges::MedcareBridge;use lance_graph_ogar::bridges::MedcareBridge;
  2. add lance-graph-ogar = { path = "../lance-graph-ogar" } to the crate's Cargo.toml

Deliberately untouched

Symbol Location Why
OgitBridge (lib.rs:222) lance_graph_ontology::bridges OGIT-native legacy bridge — correctly stayed
WoaBridge (lib.rs:331) lance_graph_ontology::bridges OGIT-native legacy bridge — correctly stayed
UnifiedBridge (lib.rs:25) lance_graph_callcenter::unified_bridge unrelated callcenter type — #585 left it untouched

No dependency cycle introduced: conformance → ogar → ontology → contract.

Local full-workspace build is blocked by unrelated missing sibling repos (ndarray/p64 path-deps), so this relies on repo CI to confirm — same as #585.

🤖 Generated with Claude Code

…plit

#585 moved the OGAR-driven port bridges (UnifiedBridge harness +
MedcareBridge/OpenProjectBridge/RedmineBridge) from lance-graph-ontology
to lance-graph-ogar, but missed one consumer: the
lance-graph-consumer-conformance crate still did
`use lance_graph_ontology::bridges::MedcareBridge;` at lib.rs:93, which
now fails to compile (MedcareBridge no longer lives there).

Fix — the same transformation #585 applied to every other consumer:
- repoint the import to `lance_graph_ogar::bridges::MedcareBridge`
- add the `lance-graph-ogar` path dep to the crate's Cargo.toml

OgitBridge (lib.rs:222) and WoaBridge (lib.rs:331) are untouched — those
are OGIT-native legacy bridges that correctly stayed in
lance-graph-ontology. The callcenter `UnifiedBridge` (lib.rs:25) is an
unrelated type, also untouched.

No dependency cycle: conformance -> ogar -> ontology -> contract.
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AdaWorldAPI, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 11 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e2e05be-baf8-494f-9173-2516771cdf59

📥 Commits

Reviewing files that changed from the base of the PR and between 5a1f187 and 666e359.

📒 Files selected for processing (2)
  • crates/lance-graph-consumer-conformance/Cargo.toml
  • crates/lance-graph-consumer-conformance/src/lib.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@AdaWorldAPI

Copy link
Copy Markdown
Owner Author

Drift ledger — full accounting of the #585 move

This PR is the code half of cleaning up after #585 (which moved the
OGAR-driven bridges lance-graph-ontologylance-graph-ogar to keep
OGIT free of ogar-vocab). Posting the complete drift surface so a
reviewer can confirm nothing else was missed, and so a future session
doesn't reintroduce the coupling.

Invariant to preserve: OGIT (lance-graph-ontology) must not depend on
ogar-vocab. The OGAR-driven bridges (UnifiedBridge<P: PortSpec> +
OpenProjectBridge/RedmineBridge/MedcareBridge) live in
lance-graph-ogar. The OGIT-native legacy bridges (OgitBridge,
WoaBridge, SharePointBridge, SpearBridge) stay in
lance-graph-ontology.

Swept all four repos for lance_graph_ontology::bridges::{UnifiedBridge, OpenProject*, Redmine*, Medcare*, *Port, *_CODEBOOK}. Results:

Ref Kind Status
lance-graph-consumer-conformance/src/lib.rs:93 (MedcareBridge) code — compile break ✅ fixed in this PR
.claude/plans/unified-bridge-consumer-migration-v1.md:28 parallel-session scratch plan ⏸ left as-is (not authoritative)
.claude/specs/td-super-domain-subcrates.md:96 spec, annotated // until fully extracted ⏸ left as-is (deliberately transitional)
redmine-rs, openproject-nexgen-rs ✅ zero refs — they consume ogar-vocab directly, never the bridges

Deliberately untouched in the conformance crate: OgitBridge
(lib.rs:222) and WoaBridge (lib.rs:331) — OGIT-native, correctly stayed
in lance-graph-ontology. The callcenter UnifiedBridge (lib.rs:25) is an
unrelated type.

Companion: OGAR #92 fixes the docs half — the ogar-vocab::ports
rustdoc (4 stale lance_graph_ontology references) and the
CLASSVIEW-MATERIALIZATION-PLAN.md §0 picture + §3 C4/C5 table, with a
"how C4+C5 actually landed" note tracing planned-in-port-repos → unified
harness (#570) → lance-graph-ontology (#558/#559) → lance-graph-ogar
(#585).

Local full-workspace build is blocked by unrelated missing sibling repos
(ndarray/p64 path-deps), so the conformance compile relies on repo CI —
same constraint #585 had.

@AdaWorldAPI AdaWorldAPI merged commit fc7b2c9 into main Jun 21, 2026
6 checks passed
AdaWorldAPI pushed a commit that referenced this pull request Jun 21, 2026
Lockfile picks up the disambiguated lance-graph-contract (path + git)
from the rebased dependency graph. No source changes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VGXeWN4XfVjteBVcVeuLo4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant