orchestration spine: run_cycle (F5) + dispatch_via (F6)#17
Merged
Conversation
The rs-graph-llm half of the ActionHandler<>RBAC<>orchestration spine (depends on lance-graph commit_via/ClassRbac, F1-F3). F5 graph-flow-kanban::run_cycle + CycleOutcome — the end-to-end spine: resolve an ActionDef by (classid,predicate) from a provided manifest, drive the existing KanbanPlanEnvelope Planning->CognitiveWork->Evaluation (deterministic Flow progression), commit_via at the decision point (the real MUL gate), map ActionState onto the terminal column (Committed->Commit, Pending->Plan, Cancelled/Failed->Prune). Generic over a provided manifest + ClassRbac (kgV: no thinking-style/provider/SoA import). Unknown predicate -> Prune (no unwrap). F6 graph-flow-action::dispatch_via — the executor-side convergence: mirrors dispatch but routes the cold floor through commit_via (ClassRbac) instead of commit (ActorContext), closing the 'executor still on the old RBAC surface' half of the gap. dispatch untouched (siblings, not nested). Tests: kanban 12 (incl 4 run_cycle), action 11 (incl 5 dispatch_via). clippy+fmt clean. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EYvNjD8M8LMNYbRy3gq2FP
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rs-graph-llm half of the ActionHandler ⟷ RBAC ⟷ orchestration spine (F5 + F6). Depends on the lance-graph side (
commit_via/ClassRbac, F1–F3): AdaWorldAPI/lance-graph#601. Built from.claude/plans/integration-actionhandler-rbac-orchestration-v1.md(5+3-hardened, one-agent-per-file, central uncomment+compile).F5
graph-flow-kanban::run_cycle+CycleOutcome— the end-to-end spineResolve an
ActionDefby(classid, predicate)from a provided manifest → drive the existingKanbanPlanEnvelopePlanning → CognitiveWork → Evaluation(deterministicFlowprogression — entering the work is not the MUL decision) →commit_viaat the decision point with the real MULgate→ mapActionStateonto the terminal column (Committed → Commit,Pending → Plan,Cancelled/Failed → Prune). Generic over a provided manifest +ClassRbac(kgV invariant: no thinking-style / provider / SoA import). Unknown predicate →Prune(nounwrap).F6
graph-flow-action::dispatch_via— executor-side convergenceMirrors
dispatchbut routes the cold floor throughcommit_via(ClassRbac) instead ofcommit(ActorContext), closing the "executor still on the old RBAC surface" half of the gap.dispatchuntouched — siblings, not nested.Tests / gates
graph-flow-kanban12 (incl 4run_cycle) ·graph-flow-action11 (incl 5dispatch_via) — green; clippy + fmt clean. Both crates staylance-graph-contract-only (no new deps).🤖 Generated with Claude Code
Generated by Claude Code