Add server side route#68
Open
gloskull wants to merge 2 commits into
Open
Conversation
- Created typed service layer in `apps/dashboard/lib/data/` for passes, guilds, members, activity, and settings. - Refactored API routes in `apps/dashboard/app/api/` to use the new service layer. - Added input validation and consistent error handling to API routes. - Migrated dashboard frontend pages to fetch data via API routes instead of direct mock data imports. - Refactored Settings page to use controlled components for better React practices. - Implemented a comprehensive test suite for all new API endpoints. - Fixed minor issues in mock repositories and API helpers to support the new boundary. Co-authored-by: gloskull <189399494+gloskull@users.noreply.github.com>
…9087160771705251 Add server-side route handlers for dashboard data
Author
|
Done with this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes a stable server-side boundary for the GuildPass dashboard by introducing a typed service layer and corresponding API routes for core entities (passes, guilds, members, activity, and settings).
Key changes include:
apps/dashboard/lib/data/provide a clean interface between the API and data repositories.apps/dashboard/app/api/now call these services, validate request parameters, and return consistent JSON shapes.This work fulfills the requirements for issue #49 and provides a solid foundation for future live integrations.
Closes #49