Updated eslint and test dependencies#1172
Conversation
| module.exports = { | ||
| extends: ['@addepar', '@addepar/eslint-config/ember'], | ||
| parser: 'babel-eslint', | ||
| root: true, |
There was a problem hiding this comment.
Based on ember-cli@5.12 blueprints. I didn't introduce eslint@v9 and flat config to limit scope.
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Run Tests | ||
| run: node_modules/.bin/ember try:one ${{ matrix.ember-version }} --skip-cleanup |
There was a problem hiding this comment.
Not a good practice to refer to node_modules/.bin/ember (the correct path may depend on which package manager is used).
| # ember-try | ||
| .node_modules.ember-try/ | ||
| bower.json.ember-try | ||
| package.json.ember-try | ||
| yarn.lock.ember-try |
There was a problem hiding this comment.
Not needed in ember-try@v4.
| @@ -53,12 +53,21 @@ | |||
| js-tokens "^4.0.0" | |||
| picocolors "^1.0.0" | |||
|
|
|||
| "@babel/code-frame@^7.27.1": | |||
There was a problem hiding this comment.
I only ran yarn install. I normally run yarn-deuplicate in my projects afterwards, but didn't here to be on the safe side.
ijlee2
force-pushed
the
update-dependencies
branch
from
c9da16a to
5698750
Compare
mixonic
force-pushed
the
update-dependencies
branch
from
66d175e to
dc3ca9a
Compare
mixonic
left a comment
mixonic
left a comment
There was a problem hiding this comment.
Approving to allow tests to advance
| ENV['ember-a11y-testing'] = { | ||
| componentOptions: { | ||
| turnAuditOff: true, // Change to true to disable the audit in development | ||
| visualNoiseLevel: 2, | ||
| axeViolationClassNames: ['alert-box', 'alert-box--a11y'], | ||
| }, |
There was a problem hiding this comment.
Where does this configuration migrate to?
There was a problem hiding this comment.
The configuration was meant for the dummy app, so I'd guess tests/dummy/config/environment.js. You'll want to check if ember-a11y-testing still supports these options.
https://github.com/ember-a11y/ember-a11y-testing/tree/v7.1.2-ember-a11y-testing
|
Seems like Ember 3.12 tests fail reliably here- But good news, we can just drop Ember 3.12 from the CI suite on |
mixonic
force-pushed
the
update-dependencies
branch
from
dc3ca9a to
3fb4bbb
Compare
|
I've force pushed to rebase atop |
|
Included in |
2 participants
Background
We use and maintain a fork of
ember-tableat work, and noticed that the pod structure is still used for components. Generally speaking,ember-source@6.0.0removed pod support for components, soember-tablemay end up becoming a blocker to developers who want to update Ember to v6.I suspect that the
ember-releasescenario (i.e.6.4.0) is currently passing, because the classic components make use of thelayoutkey. Removing the pod structure now would help maintainers and contributors glimmerize these components (Glimmer + pod doesn't work) and introduce the v2 addon format.What changed?
In this pull request, I updated
eslintand test dependencies so that we can keep this project up-to-date. The actual unpodding is done in #1173.